Bug 228824 – WebKit::SampleBufferDisplayLayer needs to handle GPUProcess crash

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

WebKit::SampleBufferDisplayLayer needs to handle GPUProcess crash

[Radar WebKit Bug Importer]

<rdar://problem/81564477>

[youenn fablet]

Created attachment 434982 [details]
Patch

[Eric Carlson]

Comment on attachment 434982 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434982&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:341
> +    destroyLayers();
> +    updateLayersAsNeeded();

There are three status values: "unknown", "rendering", and "failed".  Do we really want to destroy the layers every time the status changes?

[youenn fablet]

Good point, we should rename it to sampleBufferDisplayLayerStatusFailed.

[youenn fablet]

And only call it when rendering fails.

[Peng Liu]

Comment on attachment 434982 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434982&action=review

> Source/WebCore/ChangeLog:3
> +        WebKit::SampleBufferDisplayLayer needs to handle GPUProcess crash

Will this patch fix bug 228759?

[youenn fablet]

Created attachment 435005 [details]
Patch

[youenn fablet]

Created attachment 435061 [details]
Patch

[youenn fablet]

(In reply to Peng Liu from comment #6)
> Comment on attachment 434982 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=434982&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        WebKit::SampleBufferDisplayLayer needs to handle GPUProcess crash
> 
> Will this patch fix bug 228759?

No, bug 228759 is due to an unrelated regression

[EWS]

Committed r280731 (240318@main): <https://commits.webkit.org/240318@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435061 [details].