Bug 228759 – [GPUP] Test WebKit2.CrashGPUProcessAfterApplyingConstraints fails when Media in GPU Process is enabled

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Peng Liu]

/Volumes/Data/webkit/OpenSource/Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:82
Expected equality of these values:
  @"PASS"
    Which is: "PASS"
  [message body]
    Which is: "FAIL checkConstraints, width is not 320 but 640"

worker/0 TestWebKitAPI.WebKit2.CrashGPUProcessAfterApplyingConstraints Failed

[Radar WebKit Bug Importer]

<rdar://problem/81529641>

[youenn fablet]

Created attachment 435060 [details]
Patch

[youenn fablet]

@Phil, is reverting this change breaking GStreamer backend?
How about if GStreamerVideoCaptureSource is wrapped around a RealtimeVideoSource?

[youenn fablet]

Comment on attachment 435060 [details]
Patch

Mac-wk2 debug error is unrelated

[youenn fablet]

@Eric, it seems https://bugs.webkit.org/show_bug.cgi?id=228795 did not fix the audio shared unit assert.

[Geoffrey Garen]

Comment on attachment 435060 [details]
Patch

r=me

[youenn fablet]

Comment on attachment 435060 [details]
Patch

Landing fix since it removes the regression.
@Philn, let me know if you need further help for GStreamer layer

[EWS]

Committed r280732 (240319@main): <https://commits.webkit.org/240319@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435060 [details].

[Philippe Normand]

(In reply to youenn fablet from comment #7)
> Comment on attachment 435060 [details]
> Patch
> 
> Landing fix since it removes the regression.
> @Philn, let me know if you need further help for GStreamer layer

Maybe it fixed your regression but it introduced another one in WPE/GTK:
https://bugs.webkit.org/show_bug.cgi?id=228941

I think I'll have to add a ifdef there, I don´t see how else to fix this, the mock sources of Cocoa and GStreamer ports differ regarding constraints validation.

[youenn fablet]

(In reply to Philippe Normand from comment #9)
> (In reply to youenn fablet from comment #7)
> > Comment on attachment 435060 [details]
> > Patch
> > 
> > Landing fix since it removes the regression.
> > @Philn, let me know if you need further help for GStreamer layer
> 
> Maybe it fixed your regression but it introduced another one in WPE/GTK:
> https://bugs.webkit.org/show_bug.cgi?id=228941
> 
> I think I'll have to add a ifdef there, I don´t see how else to fix this,
> the mock sources of Cocoa and GStreamer ports differ regarding constraints
> validation.

Could you try updating GStreamer to wrap GStreamerVideoCaptureSource with a RealtimeVideoSource?
That is how it is used by other classes like AVVideoCaptureSource. Ideally RealtimeVideoCaptureSource should not be a RealtimeMediaSource, but I haven't refactored the code to do so.

[Philippe Normand]

(In reply to youenn fablet from comment #10)
> (In reply to Philippe Normand from comment #9)
> > (In reply to youenn fablet from comment #7)
> > > Comment on attachment 435060 [details]
> > > Patch
> > > 
> > > Landing fix since it removes the regression.
> > > @Philn, let me know if you need further help for GStreamer layer
> > 
> > Maybe it fixed your regression but it introduced another one in WPE/GTK:
> > https://bugs.webkit.org/show_bug.cgi?id=228941
> > 
> > I think I'll have to add a ifdef there, I don´t see how else to fix this,
> > the mock sources of Cocoa and GStreamer ports differ regarding constraints
> > validation.
> 
> Could you try updating GStreamer to wrap GStreamerVideoCaptureSource with a
> RealtimeVideoSource?

I tried already, didn't change anything :(