Bug 228761 - Use Observer in place of VideoFullscreenManagerProxyClient
Summary: Use Observer in place of VideoFullscreenManagerProxyClient
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-03 17:22 PDT by Jean-Yves Avenard [:jya]
Modified: 2021-08-04 16:47 PDT (History)
2 users (show)

See Also:


Attachments
Patch (13.37 KB, patch)
2021-08-03 21:46 PDT, Jean-Yves Avenard [:jya]
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2021-08-03 17:22:31 PDT
This will be a nicer fix to bug 228740.

We could use a WTF::Observer to notify clients that the PiP/FullScreen state has changed without having to worry about set/clearing clients.
Comment 1 Radar WebKit Bug Importer 2021-08-03 17:24:01 PDT
<rdar://problem/81489026>
Comment 2 Jean-Yves Avenard [:jya] 2021-08-03 21:46:26 PDT
Created attachment 434884 [details]
Patch
Comment 3 EWS 2021-08-04 16:47:53 PDT
Committed r280670 (240275@main): <https://commits.webkit.org/240275@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434884 [details].