Bug 228740 – REGRESSION (r280568): ASSERTION FAILED: videoFullscreenManager->client() == &_videoFullscreenManagerProxyClient

• Status: VERIFIED
• Resolution: FIXED
• Component: Media

TestWebKitAPI.CloseWebViewAfterEnterFullscreen.ElementFullscreen
TestWebKitAPI.CloseWebViewAfterEnterFullscreen.VideoFullscreen
TestWebKitAPI.CloseWebViewDuringEnterFullscreen.ElementFullscreen
TestWebKitAPI.CloseWebViewDuringEnterFullscreen.VideoFullscreen
TestWebKitAPI.ExitFullscreenOnEnterPiP.ElementFullscreen
TestWebKitAPI.ExitFullscreenOnEnterPiP.VideoFullscreen
TestWebKitAPI.Fullscreen.Delegate
TestWebKitAPI.Fullscreen.Focus
TestWebKitAPI.Fullscreen.PointerLeave
TestWebKitAPI.Fullscreen.RemoveNodeBeforeEnter
TestWebKitAPI.TopContentInset.Fullscreen
TestWebKitAPI.WKWebViewCloseAllMediaPresentations.VideoFullscreen

Are crashing on MacOS Debug.

ASSERTION FAILED: videoFullscreenManager->client() == &_videoFullscreenManagerProxyClient
        /Volumes/Data/worker/bigsur-debug/build/Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm(651) : -[WKFullScreenWindowController setVideoFullscreenManagerClient:]
        1   0x111b924f9 WTFCrash
        2   0x11a0b5b7b WTFCrashWithInfo(int, char const*, char const*, int)
        3   0x11b9ad212 -[WKFullScreenWindowController setVideoFullscreenManagerClient:]
        4   0x11b9ad553 -[WKFullScreenWindowController windowDidEnterFullScreen:]
        5   0x7fff2067210d __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__
        6   0x7fff2070db6c ___CFXRegistrationPost_block_invoke
        7   0x7fff2070daea _CFXRegistrationPost
        8   0x7fff2064338e _CFXNotificationPost
        9   0x7fff213b1dc8 -[NSNotificationCenter postNotificationName:object:userInfo:]
        10  0x7fff239a5380 -[NSWindow(NSFullScreen) _didEnterFullScreen]
        11  0x7fff233874eb -[_NSWindowEnterFullScreenTransitionController doAfterEnterFullScreen]
        12  0x7fff237f572c -[_NSEnterFullScreenTransitionController _performFinalTransitionCleanup]
        13  0x7fff237f7682 ___NSRunLoopTimerCreateWithHandler_block_invoke
        14  0x7fff206952b9 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__
        15  0x7fff20694dad __CFRunLoopDoTimer
        16  0x7fff2069490a __CFRunLoopDoTimers
        17  0x7fff2067b4d3 __CFRunLoopRun
        18  0x7fff2067a64c CFRunLoopRunSpecific
        19  0x7fff21408647 -[NSRunLoop(NSRunLoop) runMode:beforeDate:]
        20  0x1076b993e TestWebKitAPI::Util::run(bool*)
        21  0x106c6ce84 TestWebKitAPI::CloseWebViewAfterEnterFullscreen_ElementFullscreen_Test::TestBody()
        22  0x10794f224 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)
        23  0x107911a1b void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)
        24  0x107911953 testing::Test::Run()
        25  0x107912b24 testing::TestInfo::Run()
        26  0x107913c65 testing::TestSuite::Run()
        27  0x107922d8d testing::internal::UnitTestImpl::RunAllTests()
        28  0x107954864 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)
        29  0x10792272b bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)
        30  0x1079225fd testing::UnitTest::Run()
        31  0x107631561 RUN_ALL_TESTS()
        LEAK: 1 WebPage


TestWebKitAPI.WebKit.CreateNewPageDelegateFrameLoadState

Also started timing out at the same timing, so might be related.

History: https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&test=TestWebKitAPI.CloseWebViewAfterEnterFullscreen.VideoFullscreen&test=TestWebKitAPI.CloseWebViewDuringEnterFullscreen.ElementFullscreen&test=TestWebKitAPI.CloseWebViewDuringEnterFullscreen.VideoFullscreen&test=TestWebKitAPI.ExitFullscreenOnEnterPiP.ElementFullscreen&test=TestWebKitAPI.ExitFullscreenOnEnterPiP.VideoFullscreen&test=TestWebKitAPI.Fullscreen.Delegate&test=TestWebKitAPI.Fullscreen.Focus&test=TestWebKitAPI.Fullscreen.PointerLeave&test=TestWebKitAPI.Fullscreen.RemoveNodeBeforeEnter&test=TestWebKitAPI.TopContentInset.Fullscreen&test=TestWebKitAPI.WKWebViewCloseAllMediaPresentations.VideoFullscreen&test=TestWebKitAPI.AppleLanguagesTest.UpdateAppleLanguages&test=TestWebKitAPI.WebKit.CreateNewPageDelegateFrameLoadState

[Radar WebKit Bug Importer]

<rdar://problem/81464301>

History indicates that it started from this change: https://trac.webkit.org/changeset/280568/webkit

https://build.webkit.org/#/builders/23/builds/3080/steps/17/logs/stdio

[Jean-Yves Avenard [:jya]]

Created attachment 434878 [details]
Patch

[EWS]

Committed r280628 (240241@main): <https://commits.webkit.org/240241@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434878 [details].