Bug 228697 - Replace webkit- prefix properties with Standard Properties in Source/
Summary: Replace webkit- prefix properties with Standard Properties in Source/
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sonia Singla
URL:
Keywords: InRadar
Depends on:
Blocks: 228546
  Show dependency treegraph
 
Reported: 2021-08-02 03:17 PDT by Sonia Singla
Modified: 2021-08-24 21:53 PDT (History)
16 users (show)

See Also:


Attachments
Patch (11.59 KB, patch)
2021-08-02 05:14 PDT, Sonia Singla
no flags Details | Formatted Diff | Diff
Patch (11.61 KB, patch)
2021-08-02 07:46 PDT, Sonia Singla
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sonia Singla 2021-08-02 03:17:48 PDT
Replace webkit- prefix properties with Standard Properties in Source/ directory
Comment 1 Sonia Singla 2021-08-02 05:14:17 PDT
Created attachment 434747 [details]
Patch
Comment 2 Sam Sneddon [:gsnedders] 2021-08-02 06:24:15 PDT
Comment on attachment 434747 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434747&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:414
> -    -webkit-margin-start: 16px;
> +    margin-block-start: 16px;

You've consistently changed -webkit-margin-start to margin-block-start, but it should be margin-inline-start. I suspect this accounts for all the failures on EWS.
Comment 3 Sonia Singla 2021-08-02 07:46:16 PDT
Created attachment 434750 [details]
Patch
Comment 4 Sonia Singla 2021-08-02 20:02:46 PDT
>  You've consistently changed -webkit-margin-start to margin-block-start, but it should be margin-inline-start. I suspect this accounts for all the failures on EWS.

Done, sorry it was done by mistake with find and replace
Comment 5 EWS 2021-08-02 20:37:02 PDT
Committed r280581 (240203@main): <https://commits.webkit.org/240203@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434750 [details].
Comment 6 Radar WebKit Bug Importer 2021-08-02 20:38:19 PDT
<rdar://problem/81442373>