Bug 228546 - CSS cleanup: Convert -webkit prefixed CSS Logical properties to standard properties
Summary: CSS cleanup: Convert -webkit prefixed CSS Logical properties to standard prop...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 228548 228697 228730
Blocks:
  Show dependency treegraph
 
Reported: 2021-07-28 04:28 PDT by Sonia Singla
Modified: 2021-08-04 04:29 PDT (History)
3 users (show)

See Also:


Attachments
List of current usage outside of benchmarks and LayoutTests (10.77 KB, text/plain)
2021-07-30 06:31 PDT, Sam Sneddon [:gsnedders]
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sonia Singla 2021-07-28 04:28:54 PDT
In WebKit, some internal stylesheets use the legacy -webkit prefixed CSS Logical properties (e.g. https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-border-before ). Should instead replace them with the equivalent standard versions (e.g. https://developer.mozilla.org/en-US/docs/Web/CSS/border-block-start ).

Probably we can convert it into a meta bug.
Comment 1 Sam Sneddon [:gsnedders] 2021-07-30 06:31:04 PDT
Created attachment 434618 [details]
List of current usage outside of benchmarks and LayoutTests

There isn't that much in way of usage from the look of it, practically all of it been within the UA stylesheets, which should be easy to change if anyone wants to.
Comment 2 Frédéric Wang (:fredw) 2021-08-02 02:01:30 PDT
(In reply to Sam Sneddon [:gsnedders] from comment #1)
> Created attachment 434618 [details]
> List of current usage outside of benchmarks and LayoutTests
> 
> There isn't that much in way of usage from the look of it, practically all
> of it been within the UA stylesheets, which should be easy to change if
> anyone wants to.

Thanks Sam. Yes, that matches what Sonia found. The ones in CSSProperties.json should be kept as long as we continue to support legacy names. I think the proposal was to split the work like this:

(1) Replace those related to CSS completion (bug 228548) -- it was commented there that ContextualDocumentationDatabase.js (and Jetstream benchmarks) can be ignored.

(2) Replace those in internal CSS stylesheets.

(3) Replace those in internal LayoutTests (that should be safe unless they test specifically legacy names). It seems there are more in imported WPT tests, but it's just because they have not been synchronized with upstream WPT.
Comment 3 Radar WebKit Bug Importer 2021-08-04 04:29:15 PDT
<rdar://problem/81508886>