Bug 228631 – RemoteAudioMediaStreamTrackRendererInternalUnit should handle changes of requested sampleCount

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

RemoteAudioMediaStreamTrackRendererInternalUnit should handle changes of requested sampleCount

[youenn fablet]

<rdar://80690191>

[youenn fablet]

Created attachment 434609 [details]
Patch

[Eric Carlson]

Comment on attachment 434609 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434609&action=review

> Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp:182
> +    uint64_t requestedSamplesCount = m_generateOffset;

Nit: could be `auto`

[Simon Fraser (smfr)]

Comment on attachment 434609 [details]
Patch

Can this be tested?

[youenn fablet]

(In reply to Simon Fraser (smfr) from comment #4)
> Comment on attachment 434609 [details]
> Patch
> 
> Can this be tested?

I tested it manually but there is no easy way to test it automatically.

[youenn fablet]

Created attachment 434640 [details]
Patch for landing

[Simon Fraser (smfr)]

(In reply to youenn fablet from comment #5)
> (In reply to Simon Fraser (smfr) from comment #4)
> > Comment on attachment 434609 [details]
> > Patch
> > 
> > Can this be tested?
> 
> I tested it manually but there is no easy way to test it automatically.

Can we file a bug to create a mechanism for testing this kind of audio stuff?

[youenn fablet]

(In reply to Simon Fraser (smfr) from comment #7)
> (In reply to youenn fablet from comment #5)
> > (In reply to Simon Fraser (smfr) from comment #4)
> > > Comment on attachment 434609 [details]
> > > Patch
> > > 
> > > Can this be tested?
> > 
> > I tested it manually but there is no easy way to test it automatically.
> 
> Can we file a bug to create a mechanism for testing this kind of audio stuff?

I filed https://bugs.webkit.org/show_bug.cgi?id=228680

[EWS]

Committed r280516 (240148@main): <https://commits.webkit.org/240148@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434640 [details].