Bug 228593 – [Cocoa|WK1] -[NSAttributeString loadFromHTML...] methods will disable bluetooth route switching

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

[Cocoa|WK1] -[NSAttributeString loadFromHTML...] methods will disable bluetooth route switching

[Jer Noble]

<rdar://81160969>

[Jer Noble]

Created attachment 434538 [details]
Patch

[Sam Weinig]

Comment on attachment 434538 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434538&action=review

> Source/WebCore/platform/audio/ios/AudioSessionIOS.mm:31
> +#import "DeprecatedGlobalSettings.h"

Using DeprecatedGlobalSettings.h from platform/ is a layering violation (DeprecatedGlobalSettings.h is not part of platform/). The pattern to use here is usually to pass the data down from the WebCore layer or via delegation.

[Jer Noble]

(In reply to Sam Weinig from comment #3)
> Comment on attachment 434538 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=434538&action=review
> 
> > Source/WebCore/platform/audio/ios/AudioSessionIOS.mm:31
> > +#import "DeprecatedGlobalSettings.h"
> 
> Using DeprecatedGlobalSettings.h from platform/ is a layering violation
> (DeprecatedGlobalSettings.h is not part of platform/). The pattern to use
> here is usually to pass the data down from the WebCore layer or via
> delegation.

DeprecatedGlobalSettings is used everywhere in platform/. It should probably be moved in there rather than have every use require some kind of delegate push.

[Jer Noble]

(In reply to Jer Noble from comment #4)
> (In reply to Sam Weinig from comment #3)
> > Comment on attachment 434538 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=434538&action=review
> > 
> > > Source/WebCore/platform/audio/ios/AudioSessionIOS.mm:31
> > > +#import "DeprecatedGlobalSettings.h"
> > 
> > Using DeprecatedGlobalSettings.h from platform/ is a layering violation
> > (DeprecatedGlobalSettings.h is not part of platform/). The pattern to use
> > here is usually to pass the data down from the WebCore layer or via
> > delegation.
> 
> DeprecatedGlobalSettings is used everywhere in platform/. It should probably
> be moved in there rather than have every use require some kind of delegate
> push.

In fact, there are 4 uses outside of platform/, and 18 inside platform/.

[Jer Noble]

Filed bug #228594 to track fixing the layering violation (for this code and all other uses).

[Jer Noble]

Created attachment 434550 [details]
Patch

[Eric Carlson]

Comment on attachment 434550 [details]
Patch

r=me once the bots are happy

[Jer Noble]

Created attachment 434551 [details]
Patch

[Jer Noble]

Created attachment 434555 [details]
Patch for landing

[Jer Noble]

Created attachment 434558 [details]
Patch for landing

[EWS]

Committed r280462 (240097@main): <https://commits.webkit.org/240097@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434558 [details].