Bug 228594 - Move DeprecatedGlobalSettings into platform/
Summary: Move DeprecatedGlobalSettings into platform/
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
Keywords: InRadar
Depends on:
Reported: 2021-07-29 11:19 PDT by Jer Noble
Modified: 2021-08-05 11:20 PDT (History)
7 users (show)

See Also:

Patch (4.75 KB, patch)
2021-07-29 11:22 PDT, Jer Noble
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (27.50 KB, patch)
2021-07-29 11:25 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (5.54 KB, patch)
2021-07-29 11:25 PDT, Jer Noble
jer.noble: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2021-07-29 11:19:06 PDT
Move DeprecatedGlobalSettings into platform/
Comment 1 Jer Noble 2021-07-29 11:22:34 PDT
Created attachment 434541 [details]
Comment 2 Jer Noble 2021-07-29 11:25:09 PDT
Created attachment 434543 [details]
Comment 3 Jer Noble 2021-07-29 11:25:48 PDT
Created attachment 434544 [details]
Comment 4 Jer Noble 2021-07-29 11:51:50 PDT
Comment on attachment 434544 [details]

We'll need to replace the calls to HTMLMediaElement in here for this to work.
Comment 5 Sam Weinig 2021-07-29 13:53:56 PDT
Please consider not doing this. Platform code needs to avoid singletons just as much as WebCore, and propagating this pattern and establishing it as kosher rather than fixing the real issue doesn't seem like the right direction to me.

Rather, we should working to make more of platform self contained and not dependent on global state.
Comment 6 Radar WebKit Bug Importer 2021-08-05 11:20:16 PDT