RESOLVED FIXED228563
[ews-build.webkit.org] Verify GitHub integrity in commit queue 
https://bugs.webkit.org/show_bug.cgi?id=228563
Summary [ews-build.webkit.org] Verify GitHub integrity in commit queue
Jonathan Bedard
Reported 2021-07-28 12:43:58 PDT
We need to more quickly detect cases where a our GitHub mirror isn't correct because of a mistake git-svn has made. We have a script to detect this already, we just need to run it in automation.
Attachments
Patch (3.37 KB, patch)
2021-07-28 12:47 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (4.23 KB, patch)
2021-07-28 13:22 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.32 KB, patch)
2021-07-28 13:31 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-07-28 12:44:15 PDT
<rdar://problem/81230685>
Jonathan Bedard
Comment 2 2021-07-28 12:47:48 PDT
Created attachment 434450 [details] Patch
Jonathan Bedard
Comment 3 2021-07-28 13:22:31 PDT
Created attachment 434454 [details] Patch
Aakash Jain
Comment 4 2021-07-28 13:27:50 PDT
Comment on attachment 434454 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434454&action=review > Tools/CISupport/ews-build/steps.py:3454 > +class VerifyGitHubIntegrity(steps.ShellSequence): Maybe we should add a FIXME here for stop running it after we fully move to git
Jonathan Bedard
Comment 5 2021-07-28 13:28:36 PDT
(In reply to Aakash Jain from comment #4) > Comment on attachment 434454 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=434454&action=review > > > Tools/CISupport/ews-build/steps.py:3454 > > +class VerifyGitHubIntegrity(steps.ShellSequence): > > Maybe we should add a FIXME here for stop running it after we fully move to > git Good idea on the FIXME, will add
Jonathan Bedard
Comment 6 2021-07-28 13:31:49 PDT
Created attachment 434456 [details] Patch for landing
EWS
Comment 7 2021-07-28 14:36:34 PDT
Committed r280399 (240040@main): <https://commits.webkit.org/240040@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434456 [details].
Note You need to log in before you can comment on or make changes to this bug.