Bug 228563 - [ews-build.webkit.org] Verify GitHub integrity in commit queue
Summary: [ews-build.webkit.org] Verify GitHub integrity in commit queue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-28 12:43 PDT by Jonathan Bedard
Modified: 2021-09-09 06:35 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.37 KB, patch)
2021-07-28 12:47 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (4.23 KB, patch)
2021-07-28 13:22 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (4.32 KB, patch)
2021-07-28 13:31 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-07-28 12:43:58 PDT 
We need to more quickly detect cases where a our GitHub mirror isn't correct because of a mistake git-svn has made. We have a script to detect this already, we just need to run it in automation.
Comment 1 Radar WebKit Bug Importer 2021-07-28 12:44:15 PDT 
<rdar://problem/81230685>
Comment 2 Jonathan Bedard 2021-07-28 12:47:48 PDT 
Created attachment 434450 [details]
Patch
Comment 3 Jonathan Bedard 2021-07-28 13:22:31 PDT 
Created attachment 434454 [details]
Patch
Comment 4 Aakash Jain 2021-07-28 13:27:50 PDT 
Comment on attachment 434454 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434454&action=review

> Tools/CISupport/ews-build/steps.py:3454
> +class VerifyGitHubIntegrity(steps.ShellSequence):

Maybe we should add a FIXME here for stop running it after we fully move to git
Comment 5 Jonathan Bedard 2021-07-28 13:28:36 PDT 
(In reply to Aakash Jain from comment #4)
> Comment on attachment 434454 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=434454&action=review
> 
> > Tools/CISupport/ews-build/steps.py:3454
> > +class VerifyGitHubIntegrity(steps.ShellSequence):
> 
> Maybe we should add a FIXME here for stop running it after we fully move to
> git

Good idea on the FIXME, will add
Comment 6 Jonathan Bedard 2021-07-28 13:31:49 PDT 
Created attachment 434456 [details]
Patch for landing
Comment 7 EWS 2021-07-28 14:36:34 PDT 
Committed r280399 (240040@main): <https://commits.webkit.org/240040@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434456 [details].