Bug 230095 - Run check-github-mirror-integrity more frequently
Summary: Run check-github-mirror-integrity more frequently
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-09 06:24 PDT by Aakash Jain
Modified: 2021-10-12 13:22 PDT (History)
5 users (show)

See Also:


Attachments
[fast-cq] Patch (1.81 KB, patch)
2021-09-09 06:27 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff
Patch (1.94 KB, patch)
2021-10-12 11:14 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2021-09-09 06:24:50 PDT
Currently we run check-github-mirror-integrity on commit queue. This run much less frequently than rest of ews queues. We would like to know of any github integrity issues as soon as soon. So, it would be a good idea to run this script on one other ews queue (e.g.: watchlist ews) which runs more frequently.
Comment 1 Aakash Jain 2021-09-09 06:27:16 PDT
Created attachment 437739 [details]
[fast-cq] Patch
Comment 2 Aakash Jain 2021-09-09 06:27:36 PDT
Sample run: https://ews-build.webkit-uat.org/#/builders/2/builds/140
Comment 3 Jonathan Bedard 2021-09-09 08:23:38 PDT
I think we want a larger conversation on this.

It's a bit weird to be using EWS to do this, we justified running this in commit-queue because if GitHub is in a bad state, we want to stop folks from landing. At the same time, I understand that running this more frequently will notify us sooner...maybe we run it but don't fail the suite, just generate the emails?
Comment 4 Jonathan Bedard 2021-09-09 08:45:38 PDT
Aakash pointed out that the reason he picked this queue is because there is no bubble associated with it.
Comment 5 EWS 2021-09-09 08:57:35 PDT
Committed r282216 (241503@main): <https://commits.webkit.org/241503@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437739 [details].
Comment 6 Radar WebKit Bug Importer 2021-09-09 08:58:17 PDT
<rdar://problem/82926994>
Comment 7 Aakash Jain 2021-09-10 08:19:51 PDT
Restarted buildbot to pick up this change. Seems to be working fine, e.g.: https://ews-build.webkit.org/#/builders/21/builds/53056/steps/10/logs/stdio
Comment 8 Jonathan Bedard 2021-10-12 11:14:53 PDT
Reopening to attach new patch.
Comment 9 Jonathan Bedard 2021-10-12 11:14:55 PDT
Created attachment 440960 [details]
Patch
Comment 10 EWS 2021-10-12 13:22:45 PDT
Committed r284010 (242852@main): <https://commits.webkit.org/242852@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440960 [details].