Bug 227974 - Clean up SOAuthorizationSubFrame tests
Summary: Clean up SOAuthorizationSubFrame tests
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 227729 227925
Blocks:
  Show dependency treegraph
 
Reported: 2021-07-14 16:56 PDT by Brent Fulgham
Modified: 2021-07-21 16:56 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2021-07-14 16:56:00 PDT
In Bug 227925 we discovered that two API tests related to Extensible SSO failed consistently on the iOS simulator, and was flaky on some versions of macOS.

I had added a flag to indicate that WKWebView's "decidePolicyForSOAuthorizationLoadWithCurrentPolicy" delegate had been called, but found that this did not consistently happen. This might be because the test involves loading sub-frames of live websites, which might not always resolve and load in the 0.5 second timeout specified in the test.

=====================================

TestWebKitAPI.SOAuthorizationSubFrame.SOAuthorizationLoadPolicyIgnore
        
        /Volumes/Data/worker/ios-simulator-14-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:2586
        Value of: policyForAppSSOPerformed
          Actual: true
        Expected: false
        
TestWebKitAPI.SOAuthorizationSubFrame.SOAuthorizationLoadPolicyIgnoreAsync
        
        /Volumes/Data/worker/ios-simulator-14-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:2643
        Value of: policyForAppSSOPerformed
          Actual: true
        Expected: false

=====================================

We should investigate this further and make the tests more deterministic to avoid this problem.
Comment 1 Radar WebKit Bug Importer 2021-07-21 16:56:16 PDT
<rdar://problem/80926605>