Bug 227925 – [iOS & Mac Big Sur Release] Two SOAuthorizationSubFrame API tests are failing

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

TestWebKitAPI.SOAuthorizationSubFrame.SOAuthorizationLoadPolicyIgnore
TestWebKitAPI.SOAuthorizationSubFrame.SOAuthorizationLoadPolicyIgnoreAsync

Are failing on iOS 14 E Simulator Release on iPhone 8 and iPad Pro. There seems to be a flaky crash on Big Sur Release on iMac and iOS 14 E Simulator Debug on iPhone 8 as well.

History: https://results.webkit.org/?suite=api-tests&suite=api-tests&test=TestWebKitAPI.SOAuthorizationSubFrame.SOAuthorizationLoadPolicyIgnore&test=TestWebKitAPI.SOAuthorizationSubFrame.SOAuthorizationLoadPolicyIgnoreAsync

=====================================

TestWebKitAPI.SOAuthorizationSubFrame.SOAuthorizationLoadPolicyIgnore
        
        /Volumes/Data/worker/ios-simulator-14-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:2586
        Value of: policyForAppSSOPerformed
          Actual: true
        Expected: false
        
TestWebKitAPI.SOAuthorizationSubFrame.SOAuthorizationLoadPolicyIgnoreAsync
        
        /Volumes/Data/worker/ios-simulator-14-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:2643
        Value of: policyForAppSSOPerformed
          Actual: true
        Expected: false

=====================================

https://build.webkit.org/#/builders/28/builds/2401/steps/12/logs/stdio

[Radar WebKit Bug Importer]

<rdar://problem/80543830>

I was not able to reproduce the failure on my local machine using run-api-tests TestWebKitAPI.SOAuthorizationSubFrame.SOAuthorizationLoadPolicyIgnore --ios-simulator

[Ryan Haddad]

Probably related to https://trac.webkit.org/changeset/279755/webkit

[Brent Fulgham]

Both of these test cases load apple.com in an iframe. They have a hard-coded 0.5s timeout, which might be insufficient to consistently get the assertion right.

[Brent Fulgham]

Created attachment 433543 [details]
Patch

[Kate Cheney]

Comment on attachment 433543 [details]
Patch

r=me

Should we file a bug to track adding them back?

[Brent Fulgham]

(In reply to Kate Cheney from comment #6)
> Comment on attachment 433543 [details]
> Patch
> 
> r=me
> 
> Should we file a bug to track adding them back?

I filed Bug 227974 to do so.

[EWS]

Committed r279935 (239679@main): <https://commits.webkit.org/239679@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433543 [details].