Bug 227888 - Revert r277027: breaks GC.
Summary: Revert r277027: breaks GC.
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
Keywords: InRadar
Depends on:
Blocks: 225376
  Show dependency treegraph
Reported: 2021-07-12 14:36 PDT by Mark Lam
Modified: 2021-07-12 18:48 PDT (History)
10 users (show)

See Also:

proposed patch. (11.91 KB, patch)
2021-07-12 14:40 PDT, Mark Lam
sbarati: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2021-07-12 14:36:22 PDT
The patch in r277027 to make deletion of GCAwareJITStubRoutines incremental has a bug:the routine may not be deleted yet by the incremental sweeper before the next GC cycle, and the GC will not be happy visiting dead cell pointers in that routine.  There are also other bugs with the triggering of sweeping.

For now, we're reverting the patch, and will revisit this at a later time.
Comment 1 Mark Lam 2021-07-12 14:36:55 PDT
Comment 2 Mark Lam 2021-07-12 14:40:49 PDT
Created attachment 433362 [details]
proposed patch.
Comment 3 Mark Lam 2021-07-12 18:44:39 PDT
The fast/canvas/canvas-overloads-strokeText.html crash on the mac-AS-debug-wk2 run appears to be a pre-existing issue.  https://results.webkit.org/?suite=layout-tests&test=fast%2Fcanvas%2Fcanvas-overloads-strokeText.html shows that it crashes in a flaky manner.
Comment 4 Mark Lam 2021-07-12 18:48:44 PDT
Thanks for the review. Landed in r279861: <http://trac.webkit.org/r279861>.