RESOLVED FIXED 227888
Revert r277027: breaks GC. 
https://bugs.webkit.org/show_bug.cgi?id=227888
Summary Revert r277027: breaks GC.
Mark Lam
Reported 2021-07-12 14:36:22 PDT
The patch in r277027 to make deletion of GCAwareJITStubRoutines incremental has a bug:the routine may not be deleted yet by the incremental sweeper before the next GC cycle, and the GC will not be happy visiting dead cell pointers in that routine. There are also other bugs with the triggering of sweeping. For now, we're reverting the patch, and will revisit this at a later time.
Attachments
proposed patch. (11.91 KB, patch)
2021-07-12 14:40 PDT, Mark Lam 		saam: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2021-07-12 14:36:55 PDT
rdar://79907561
Mark Lam
Comment 2 2021-07-12 14:40:49 PDT
Created attachment 433362 [details] proposed patch.
Mark Lam
Comment 3 2021-07-12 18:44:39 PDT
The fast/canvas/canvas-overloads-strokeText.html crash on the mac-AS-debug-wk2 run appears to be a pre-existing issue. https://results.webkit.org/?suite=layout-tests&test=fast%2Fcanvas%2Fcanvas-overloads-strokeText.html shows that it crashes in a flaky manner.
Mark Lam
Comment 4 2021-07-12 18:48:44 PDT
Thanks for the review. Landed in r279861: <http://trac.webkit.org/r279861>.
Note You need to log in before you can comment on or make changes to this bug.