Bug 225376 - Enable incremental sweeping of GCAwareJITStubRoutines.
Summary: Enable incremental sweeping of GCAwareJITStubRoutines.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-04 17:49 PDT by Mark Lam
Modified: 2021-05-05 10:29 PDT (History)
11 users (show)

See Also:


Attachments
proposed patch. (12.60 KB, patch)
2021-05-04 18:20 PDT, Mark Lam
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
proposed patch. (12.85 KB, patch)
2021-05-04 18:26 PDT, Mark Lam
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
proposed patch. (13.42 KB, patch)
2021-05-04 18:41 PDT, Mark Lam
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2021-05-04 17:49:29 PDT
This is in preparation for incremental sweeping of CodeBlocks.
Comment 1 Mark Lam 2021-05-04 18:20:28 PDT
Created attachment 427718 [details]
proposed patch.
Comment 2 Mark Lam 2021-05-04 18:26:57 PDT
Created attachment 427719 [details]
proposed patch.
Comment 3 Mark Lam 2021-05-04 18:35:01 PDT
Comment on attachment 427719 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=427719&action=review

> Source/JavaScriptCore/heap/JITStubRoutineSet.h:77
> +    WTF::Range<uintptr_t> m_range { 0, 0 };

Qualifying with WTF:: here is only needed because Clang thinks this is ambiguous vs WebCore::Range (despite the "using WTF::Range" above).
Comment 4 Mark Lam 2021-05-04 18:41:05 PDT
Created attachment 427721 [details]
proposed patch.
Comment 5 Filip Pizlo 2021-05-05 10:18:01 PDT
Comment on attachment 427721 [details]
proposed patch.

I think this looks good.
Comment 6 Mark Lam 2021-05-05 10:28:59 PDT
Thanks for the review.  Landed in r277027: <http://trac.webkit.org/r277027>.
Comment 7 Radar WebKit Bug Importer 2021-05-05 10:29:21 PDT
<rdar://problem/77563716>