REOPENED 225376
Enable incremental sweeping of GCAwareJITStubRoutines. 
https://bugs.webkit.org/show_bug.cgi?id=225376
Summary Enable incremental sweeping of GCAwareJITStubRoutines.
Mark Lam
Reported 2021-05-04 17:49:29 PDT
This is in preparation for incremental sweeping of CodeBlocks.
Attachments
proposed patch. (12.60 KB, patch)
2021-05-04 18:20 PDT, Mark Lam 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
proposed patch. (12.85 KB, patch)
2021-05-04 18:26 PDT, Mark Lam 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
proposed patch. (13.42 KB, patch)
2021-05-04 18:41 PDT, Mark Lam 		fpizlo: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2021-05-04 18:20:28 PDT
Created attachment 427718 [details] proposed patch.
Mark Lam
Comment 2 2021-05-04 18:26:57 PDT
Created attachment 427719 [details] proposed patch.
Mark Lam
Comment 3 2021-05-04 18:35:01 PDT
Comment on attachment 427719 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=427719&action=review > Source/JavaScriptCore/heap/JITStubRoutineSet.h:77 > + WTF::Range<uintptr_t> m_range { 0, 0 }; Qualifying with WTF:: here is only needed because Clang thinks this is ambiguous vs WebCore::Range (despite the "using WTF::Range" above).
Mark Lam
Comment 4 2021-05-04 18:41:05 PDT
Created attachment 427721 [details] proposed patch.
Filip Pizlo
Comment 5 2021-05-05 10:18:01 PDT
Comment on attachment 427721 [details] proposed patch. I think this looks good.
Mark Lam
Comment 6 2021-05-05 10:28:59 PDT
Thanks for the review. Landed in r277027: <http://trac.webkit.org/r277027>.
Radar WebKit Bug Importer
Comment 7 2021-05-05 10:29:21 PDT
<rdar://problem/77563716>
Mark Lam
Comment 8 2021-07-12 15:14:54 PDT
Reverting in https://bugs.webkit.org/show_bug.cgi?id=227888 due to bugs in this patch.
Mark Lam
Comment 9 2021-07-12 18:51:07 PDT
Reverted in in r279861: <http://trac.webkit.org/r279861>.
Note You need to log in before you can comment on or make changes to this bug.