Bug 227367 - REGRESSION (r278746): [Mac wk1] media/media-fullscreen-return-to-inline.html is a flaky timeout
Summary: REGRESSION (r278746): [Mac wk1] media/media-fullscreen-return-to-inline.html ...
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-24 11:19 PDT by Eric Hutchison
Modified: 2021-06-28 12:02 PDT (History)
7 users (show)

See Also:

Attachments
Expectations (1.58 KB, patch)
2021-06-25 16:06 PDT, Eric Hutchison 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Hutchison 2021-06-24 11:19:58 PDT 
media/media-fullscreen-return-to-inline.html

flaky timeout on Mac wk1 queues. It appears timeout began around r278753. 

History: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=media%2Fmedia-fullscreen-return-to-inline.html&test=media%2Fmedia-fullscreen-return-to-inline.html
Comment 1 Radar WebKit Bug Importer 2021-06-24 11:20:32 PDT 
<rdar://problem/79733822>
Comment 2 Eric Hutchison 2021-06-25 13:43:07 PDT 
Was able to bisect issue to available builds 278743 to 278751.
Comment 3 Truitt Savell 2021-06-25 13:45:06 PDT 
Looking at the revisions in this range, it seems like either r278746 or r278747 could have caused this.

Chris or Wenson could you see if one of your changes could be responsible for this regression?
Comment 4 Wenson Hsieh 2021-06-25 13:47:19 PDT 
(In reply to Truitt Savell from comment #3)
> Looking at the revisions in this range, it seems like either r278746 or
> r278747 could have caused this.
> 
> Chris or Wenson could you see if one of your changes could be responsible
> for this regression?

It's definitely not r278747, since the codepaths that were changed there aren't compiled on macOS earlier than Monterey.
Comment 5 Alexey Proskuryakov 2021-06-25 15:30:52 PDT 
Re-titled based on above comments.
Comment 6 Eric Hutchison 2021-06-25 16:06:32 PDT 
Created attachment 432305 [details]
Expectations
Comment 7 EWS 2021-06-25 17:24:05 PDT 
Committed r279302 (239178@main): <https://commits.webkit.org/239178@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432305 [details].
Comment 8 Ryan Haddad 2021-06-25 17:46:52 PDT 
Reopening since the patch only updated test expectations.
Comment 9 Chris Dumez 2021-06-28 08:50:33 PDT 
--- /Volumes/Data/worker/catalina-release-tests-wk1/build/layout-test-results/media/media-fullscreen-return-to-inline-expected.txt
+++ /Volumes/Data/worker/catalina-release-tests-wk1/build/layout-test-results/media/media-fullscreen-return-to-inline-actual.txt
@@ -1,3 +1,4 @@
+FAIL: Timed out waiting for notifyDone to be called
 
 Test that a <video> pauses after exiting fullscreen when the internal property "allowsInlineMediaPlaybackAfterFullscreen" is false.
 
@@ -11,15 +12,6 @@
 EVENT(webkitpresentationmodechanged)
 EXPECTED (internals.isChangingPresentationMode(video) == 'false') OK
 EXPECTED (video.webkitDisplayingFullscreen == 'false') OK
-EXPECTED (video.paused == 'true') OK
+EXPECTED (video.paused == 'true'), OBSERVED 'false' FAIL
 RUN(video.play())
-EVENT(webkitpresentationmodechanged)
-EXPECTED (internals.isChangingPresentationMode(video) == 'false') OK
-EXPECTED (video.webkitDisplayingFullscreen == 'true') OK
-RUN(video.webkitExitFullscreen())
-EVENT(webkitpresentationmodechanged)
-EXPECTED (internals.isChangingPresentationMode(video) == 'false') OK
-EXPECTED (video.webkitDisplayingFullscreen == 'false') OK
-EXPECTED (video.paused == 'false') OK
-END OF TEST
Comment 10 Chris Dumez 2021-06-28 09:51:22 PDT 
Sadly, I am having trouble reproducing. I tried both release and debug builds with WK1. I tried running tests sequentially or in parallel.