Bug 226899 – REGRESSION: (r278544) [ Mac-wk1 ] media/media-continues-playing-after-replace-source.html is a flaky failure

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Truitt Savell]

media/media-continues-playing-after-replace-source.html

this test has been flaky failing sense the changes in https://trac.webkit.org/changeset/278544/webkit

History:
https://results.webkit.org/?suite=layout-tests&test=media/media-continues-playing-after-replace-source.html

Diff:
--- /Volumes/Data/worker/bigsur-debug-tests-wk1/build/layout-test-results/media/media-continues-playing-after-replace-source-expected.txt
+++ /Volumes/Data/worker/bigsur-debug-tests-wk1/build/layout-test-results/media/media-continues-playing-after-replace-source-actual.txt
@@ -5,7 +5,7 @@
 EVENT(playing)
 EXPECTED (testElement.currentTime > '0') OK
 Replacing the media's source element:
-EXPECTED (testElement.currentTime == '0') OK
+EXPECTED (testElement.currentTime == '0'), OBSERVED '0.205980314234375' FAIL
 EXPECTED (testElement.currentTime > '0') OK
 END OF TEST

[Radar WebKit Bug Importer]

<rdar://problem/79160701>

[Truitt Savell]

This test is effecting wk1 queues

[Chris Dumez]

Looking.

[Chris Dumez]

Created attachment 431147 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 431147 [details]
Patch

Maybe we can do the same for other media related code where we use callOnMainThread?

[Chris Dumez]

(In reply to Ryosuke Niwa from comment #5)
> Comment on attachment 431147 [details]
> Patch
> 
> Maybe we can do the same for other media related code where we use
> callOnMainThread?

Probably, I plan to follow up.

[EWS]

Committed r278746 (238707@main): <https://commits.webkit.org/238707@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431147 [details].