RESOLVED FIXED 227238
Use double instead of float where appropriate in HTML Canvas IDL
https://bugs.webkit.org/show_bug.cgi?id=227238
Summary Use double instead of float where appropriate in HTML Canvas IDL
Chris Dumez
Reported 2021-06-21 15:07:29 PDT
There are a lot of places in our HTML Canvas IDL where we're using float type, even though the specification is using double. Let's fix those.
Attachments
Patch (39.25 KB, patch)
2021-06-21 15:13 PDT, Chris Dumez
no flags
Chris Dumez
Comment 1 2021-06-21 15:13:50 PDT
Sam Weinig
Comment 2 2021-06-21 15:24:44 PDT
Comment on attachment 431915 [details] Patch Let no one ever say bullying does not work. This proves it does ;). Thanks Chris!
Devin Rousso
Comment 3 2021-06-21 15:34:02 PDT
Comment on attachment 431915 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431915&action=review > Source/WebCore/inspector/InspectorCanvasCallTracer.h:155 > macro(std::optional<float>&) \ Is this still needed anymore? > Source/WebCore/inspector/InspectorCanvasCallTracer.h:171 > macro(Vector<float>&) \ Is this still needed anymore?
Chris Dumez
Comment 4 2021-06-21 15:35:10 PDT
(In reply to Devin Rousso from comment #3) > Comment on attachment 431915 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=431915&action=review > > > Source/WebCore/inspector/InspectorCanvasCallTracer.h:155 > > macro(std::optional<float>&) \ > > Is this still needed anymore? > > > Source/WebCore/inspector/InspectorCanvasCallTracer.h:171 > > macro(Vector<float>&) \ > > Is this still needed anymore? Yes, I tried to remove them and it failed to build. I believe this is because we still have some non-standard API using float and requiring those. I updated updated the "standard" API.
Sam Weinig
Comment 5 2021-06-21 16:25:07 PDT
(In reply to Devin Rousso from comment #3) > Comment on attachment 431915 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=431915&action=review > > > Source/WebCore/inspector/InspectorCanvasCallTracer.h:155 > > macro(std::optional<float>&) \ > > Is this still needed anymore? > > > Source/WebCore/inspector/InspectorCanvasCallTracer.h:171 > > macro(Vector<float>&) \ > > Is this still needed anymore? We really got to replace that with a non-macro version at some point. We have better technology.
EWS
Comment 6 2021-06-21 17:22:54 PDT
Committed r279093 (239010@main): <https://commits.webkit.org/239010@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431915 [details].
Radar WebKit Bug Importer
Comment 7 2021-06-21 17:23:20 PDT
Note You need to log in before you can comment on or make changes to this bug.