Bug 227238 – Use double instead of float where appropriate in HTML Canvas IDL

• Status: RESOLVED
• Resolution: FIXED
• Component: Canvas

[Chris Dumez]

There are a lot of places in our HTML Canvas IDL where we're using float type, even though the specification is using double. Let's fix those.

[Chris Dumez]

Created attachment 431915 [details]
Patch

[Sam Weinig]

Comment on attachment 431915 [details]
Patch

Let no one ever say bullying does not work. This proves it does ;). 

Thanks Chris!

[Devin Rousso]

Comment on attachment 431915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431915&action=review

> Source/WebCore/inspector/InspectorCanvasCallTracer.h:155
>      macro(std::optional<float>&) \

Is this still needed anymore?

> Source/WebCore/inspector/InspectorCanvasCallTracer.h:171
>      macro(Vector<float>&) \

Is this still needed anymore?

[Chris Dumez]

(In reply to Devin Rousso from comment #3)
> Comment on attachment 431915 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=431915&action=review
> 
> > Source/WebCore/inspector/InspectorCanvasCallTracer.h:155
> >      macro(std::optional<float>&) \
> 
> Is this still needed anymore?
> 
> > Source/WebCore/inspector/InspectorCanvasCallTracer.h:171
> >      macro(Vector<float>&) \
> 
> Is this still needed anymore?

Yes, I tried to remove them and it failed to build. I believe this is because we still have some non-standard API using float and requiring those. I updated updated the "standard" API.

[Sam Weinig]

(In reply to Devin Rousso from comment #3)
> Comment on attachment 431915 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=431915&action=review
> 
> > Source/WebCore/inspector/InspectorCanvasCallTracer.h:155
> >      macro(std::optional<float>&) \
> 
> Is this still needed anymore?
> 
> > Source/WebCore/inspector/InspectorCanvasCallTracer.h:171
> >      macro(Vector<float>&) \
> 
> Is this still needed anymore?

We really got to replace that with a non-macro version at some point. We have better technology.

[EWS]

Committed r279093 (239010@main): <https://commits.webkit.org/239010@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431915 [details].

[Radar WebKit Bug Importer]

<rdar://problem/79588170>