Bug 227146 – [WebIDL] Assigning a value outside the float range to a 'float' attribute should throw a TypeError

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Chris Dumez]

Assigning a value outside the float range to a 'float' attribute should throw a TypeError, as per:
https://heycam.github.io/webidl/#es-float

Blink follows the specification but WebKit just casts the double to a float.

[Chris Dumez]

Created attachment 431723 [details]
Patch

[Sam Weinig]

We might want to fix the canvas IDLs still using float that should be double before doing this to avoid accidental fallout.

[Cameron McCormack (:heycam)]

It looks like almost all uses of floats in our canvas IDLs are `unrestricted float`, which will at least saturate out of range Number values to +/-Infinity.

[Chris Dumez]

(In reply to Cameron McCormack (:heycam) from comment #3)
> It looks like almost all uses of floats in our canvas IDLs are `unrestricted
> float`, which will at least saturate out of range Number values to
> +/-Infinity.

Right, the behavior change in this patch for unrestricted float is not large and a strict progression. I would be more concerned about APIs where we use (restricted) float instead of double.

[Sam Weinig]

Fair (just trying to bully people into fixing that because I keep forgetting to).

[EWS]

Committed r279047 (238967@main): <https://commits.webkit.org/238967@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431723 [details].

[Radar WebKit Bug Importer]

<rdar://problem/79516533>