Bug 227014 – Reimplement JSC::CachePayload without FileSystem::unmapViewOfFile and FileSystem::MappedFileData::leakHandle

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Fujii Hironori]

Reimplement JSC::CachePayload without FileSystem::unmapViewOfFile and FileSystem::MappedFileData::leakHandle

r247542 (Bug 199759) added FileSystem::unmapViewOfFile and
FileSystem::MappedFileData::leakHandle for JSC::CachePayload to
get the mapped address and to free the address.

Bug 227011 is going to add a file mapping handle to
FileSystem::MappedFileData for Windows port. Destruction of
MappedFileData should be done only by MappedFileData dtor.

[Fujii Hironori]

Created attachment 431405 [details]
Patch

[Fujii Hironori]

Created attachment 431409 [details]
Patch

[Fujii Hironori]

Could anyone review?

[Yusuke Suzuki]

I'll look soon after meeting :)

[Yusuke Suzuki]

Comment on attachment 431409 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431409&action=review

r=me

> Source/JavaScriptCore/runtime/CachePayload.cpp:38
> +    return CachePayload(std::make_pair(WTFMove(data), size));

I think we can use `std::pair { ... }` instead of `make_pair`.

> Source/JavaScriptCore/runtime/CachePayload.cpp:43
> +    return CachePayload(std::make_pair(nullptr, 0));

Ditto.

> Source/JavaScriptCore/runtime/CachePayload.cpp:49
> +    other.m_data = std::make_pair(nullptr, 0);

Ditto.

[Fujii Hironori]

Created attachment 431712 [details]
Patch for landing

[Fujii Hironori]

Comment on attachment 431712 [details]
Patch for landing

Clearing flags on attachment: 431712

Committed r279008 (238933@main): <https://commits.webkit.org/238933@main>

[Fujii Hironori]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/79470135>