Bug 227011 – [WinCairo] Turn ENABLE_SHAREABLE_RESOURCE on

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Fujii Hironori]

[WinCairo] Turn ENABLE_SHAREABLE_RESOURCE on

[Fujii Hironori]

Created attachment 431401 [details]
WIP patch

[Fujii Hironori]

Created attachment 431402 [details]
WIP patch

[Fujii Hironori]

Created attachment 431720 [details]
WIP patch

[Fujii Hironori]

Created attachment 431829 [details]
Patch

[Fujii Hironori]

Created attachment 431901 [details]
Patch

[Don Olmstead]

Comment on attachment 431901 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431901&action=review

> Source/WebKit/NetworkProcess/cache/NetworkCacheDataCurl.cpp:123
> +#if ENABLE(SHAREABLE_RESOURCE) && OS(WINDOWS)
> +RefPtr<SharedMemory> Data::tryCreateSharedMemory() const
> +{
> +    if (isNull() || !isMap())
> +        return nullptr;
> +
> +    HANDLE handle = WTF::get<FileSystem::MappedFileData>(*m_buffer).fileMapping();
> +    HANDLE newHandle;
> +    if (!DuplicateHandle(GetCurrentProcess(), handle, GetCurrentProcess(), &newHandle, 0, false, DUPLICATE_SAME_ACCESS))
> +        return nullptr;
> +
> +    return SharedMemory::adopt(newHandle, m_size, SharedMemory::Protection::ReadOnly);
> +}
> +#endif

You have any plans to do a POSIX implementation that PlayStation can use here too?

[Fujii Hironori]

(In reply to Don Olmstead from comment #6)
> You have any plans to do a POSIX implementation that PlayStation can use
> here too?

It sounds a good idea. But, not high priority for me now. My motivation was fixing a WinCairo assertion failure (Bug 225801), but unfortunately this change doesn't fix it.

[Don Olmstead]

(In reply to Fujii Hironori from comment #7)
> (In reply to Don Olmstead from comment #6)
> > You have any plans to do a POSIX implementation that PlayStation can use
> > here too?
> 
> It sounds a good idea. But, not high priority for me now. My motivation was
> fixing a WinCairo assertion failure (Bug 225801), but unfortunately this
> change doesn't fix it.

Ok can you open a bug for that part?

Builds are green so commit at your leisure

[Fujii Hironori]

Comment on attachment 431901 [details]
Patch

Clearing flags on attachment: 431901

Committed r279085 (239004@main): <https://commits.webkit.org/239004@main>

[Fujii Hironori]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/79581434>

[Fujii Hironori]

(In reply to Don Olmstead from comment #8)
> Ok can you open a bug for that part?

Yup. Filed.
  Bug 227236 – [PlayStation] Turn ENABLE_SHAREABLE_RESOURCE on