The following WPT tests fail: css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-008.html css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-011.html
Created attachment 431076 [details] Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Created attachment 431183 [details] Patch
Comment on attachment 431183 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431183&action=review > Source/WebCore/rendering/RenderGrid.cpp:1590 > LayoutUnit gridBorder = isRowAxis ? borderLogicalLeft() : borderBefore(); I wonder whether we have to do the same with borders and/or position. But that's just food for thought for another bug.
Comment on attachment 431183 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431183&action=review >> Source/WebCore/rendering/RenderGrid.cpp:1590 >> LayoutUnit gridBorder = isRowAxis ? borderLogicalLeft() : borderBefore(); > > I wonder whether we have to do the same with borders and/or position. But that's just food for thought for another bug. Note the border is the one of the grid container. So it already is resolved using the writing mode of the grid container.
Comment on attachment 431183 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431183&action=review >>> Source/WebCore/rendering/RenderGrid.cpp:1590 >>> LayoutUnit gridBorder = isRowAxis ? borderLogicalLeft() : borderBefore(); >> >> I wonder whether we have to do the same with borders and/or position. But that's just food for thought for another bug. > > Note the border is the one of the grid container. So it already is resolved using the writing mode of the grid container. Oh right. But it still stands for the childPosition right?. There are several WPT tests failing in flexbox for example related to vertical-rl due to incorrect offsetLeft and I suspect that might be the cause of issues. Not sure if also here for grid too.
<rdar://problem/79448742>
The mac-wk2-stress failure looks related to https://bugs.webkit.org/show_bug.cgi?id=225126
Created attachment 432253 [details] Patch
zsun@igalia.com does not have committer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/Tools/Scripts/webkitpy/common/config/contributors.json. Rejecting attachment 432253 [details] from commit queue.
Committed r279278 (239157@main): <https://commits.webkit.org/239157@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432253 [details].