Bug 225126 - [Stress Tests EWS] WPT tests failing in `run-layout-tests-in-guard-malloc-stress-mode`
Summary: [Stress Tests EWS] WPT tests failing in `run-layout-tests-in-guard-malloc-str...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-27 16:11 PDT by Ryan Haddad
Modified: 2021-04-28 17:05 PDT (History)
8 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2021-04-27 16:11:37 PDT
It appears that whenever stress tests EWS runs the `run-layout-tests-in-guard-malloc-stress-mode ` step for tests in the imported/w3c/web-platform-tests directory, the wptwk server isn't started, which causes the tests to fail

Example build showing a WPT test passing in the `run-layout-tests-in-stress-mode` step, but failing in in the `run-layout-tests-in-guard-malloc-stress-mode` step:
https://ews-build.webkit.org/#/builders/62/builds/1853

Test result showing the test failing with a render tree dump for about:blank: 
https://ews-build.s3-us-west-2.amazonaws.com/macOS-Release-WK2-Stress-Tests-EWS/r427118-1853-guard-malloc/results.html
Comment 1 Radar WebKit Bug Importer 2021-04-27 16:12:24 PDT
<rdar://problem/77236114>
Comment 2 Ryan Haddad 2021-04-27 16:50:47 PDT
The `run-layout-tests-in-stress-mode` test run is indeed starting wptwk, as seen in the logs (and the fact that the test passes in that mode)
https://ews-build.webkit.org/#/builders/62/builds/1853/steps/14/logs/stdio

The only difference for the `run-layout-tests-in-guard-malloc-stress-mode ` step is the addition of `--guard-malloc`, so maybe something is broken in `run-webkit-tests` itself?
Comment 3 Jonathan Bedard 2021-04-27 17:04:46 PDT
(In reply to Ryan Haddad from comment #2)
> The `run-layout-tests-in-stress-mode` test run is indeed starting wptwk, as
> seen in the logs (and the fact that the test passes in that mode)
> https://ews-build.webkit.org/#/builders/62/builds/1853/steps/14/logs/stdio
> 
> The only difference for the `run-layout-tests-in-guard-malloc-stress-mode `
> step is the addition of `--guard-malloc`, so maybe something is broken in
> `run-webkit-tests` itself?

Very strongly suspect that is the case. It's also probably a very easy fix. I'll take a look tomorrow.
Comment 4 Ryosuke Niwa 2021-04-28 11:54:37 PDT
I've seen regular layout test step reproducing the same issue too.
Comment 5 Jonathan Bedard 2021-04-28 16:40:55 PDT
This seems to be about guard-malloc specifically, not a general problem with all invocations of run-webkit-tests.
Comment 6 Jonathan Bedard 2021-04-28 17:05:01 PDT
We are starting the WPT server in guard-malloc mode, seems like the web-platforms tests may be genuinely timing out.