Bug 226703 - run-webkit-test should use python2 for wpt serve until the latest will be imported
Summary: run-webkit-test should use python2 for wpt serve until the latest will be imp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-06 17:34 PDT by Fujii Hironori
Modified: 2021-06-07 13:07 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.07 KB, patch)
2021-06-06 17:39 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2021-06-06 17:34:44 PDT
run-webkit-test should use python2 for wpt serve until the latest will be imported

See also:
  Bug 222703 – [Python 3] Update wpt/tools
  Bug 206546 – webkitpy: WebSocket server doesn't support Python 3
Comment 1 Fujii Hironori 2021-06-06 17:39:23 PDT
Created attachment 430702 [details]
Patch
Comment 2 Fujii Hironori 2021-06-06 18:06:31 PDT
EWS webkitpy-tests-python2 failed. However, it looks irrelevant to my change.

[31/1992] webkitcorepy.tests.task_pool_unittest.TaskPoolUnittest.test_invalid_shutdown failed:
  Traceback (most recent call last):
    File "/Volumes/Data/worker/WebKitPy-Tests-EWS/build/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/task_pool_unittest.py", line 176, in test_invalid_shutdown
      pool.do(wait, 2)
  AssertionError: Exception not raised
Comment 3 Fujii Hironori 2021-06-07 13:06:07 PDT
Comment on attachment 430702 [details]
Patch

Clearing flags on attachment: 430702

Committed r278569 (238567@main): <https://commits.webkit.org/238567@main>
Comment 4 Fujii Hironori 2021-06-07 13:06:11 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2021-06-07 13:07:20 PDT
<rdar://problem/78959542>