Bug 226661 - Web Inspector: mark recently added protocol commands/events as page-only
Summary: Web Inspector: mark recently added protocol commands/events as page-only
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 207446 218964 221228 221449
Blocks:
  Show dependency tree / graph
 
Reported: 2021-06-04 13:34 PDT by Devin Rousso
Modified: 2021-06-11 10:48 PDT (History)
15 users (show)

See Also:

Attachments
Patch (5.31 KB, patch)
2021-06-04 13:46 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-06-04 13:34:19 PDT 
.
Comment 1 Devin Rousso 2021-06-04 13:46:55 PDT 
Created attachment 430609 [details]
Patch
Comment 2 EWS Watchlist 2021-06-04 13:47:58 PDT 
This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.
Comment 3 Joseph Pecoraro 2021-06-04 13:50:40 PDT 
Comment on attachment 430609 [details]
Patch

rs=me, Can a Service Worker debugger do intercepts?
Comment 4 Joseph Pecoraro 2021-06-04 13:52:14 PDT 
Comment on attachment 430609 [details]
Patch

Given existing intercept methods are only for "page" this seems good! r=me
Comment 5 Devin Rousso 2021-06-04 15:04:25 PDT 
(In reply to Joseph Pecoraro from comment #3)
Can a Service Worker debugger do intercepts?

I tried enabling all the intercept commands for `"service-worker"` targets too, but it didn't work.  Also, most "resources" are actually `WI.Script` that don't have a `WI.Resource` and therefore don't go through the `Network` agent.
Comment 6 EWS 2021-06-04 16:57:46 PDT 
Committed r278511 (238510@main): <https://commits.webkit.org/238510@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430609 [details].
Comment 7 Radar WebKit Bug Importer 2021-06-04 16:58:19 PDT 
<rdar://problem/78892294>