Bug 226227 – [macOS] Support painting data detector highlights inside image overlays

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Wenson Hsieh]

.

[Wenson Hsieh]

Created attachment 429669 [details]
Patch

[Wenson Hsieh]

Created attachment 429674 [details]
Fix pre-macOS 11 build

[EWS]

Tools/Scripts/svn-apply failed to apply attachment 429674 [details] to trunk.
Please resolve the conflicts and upload a new patch.

[Wenson Hsieh]

Created attachment 429779 [details]
For EWS

[EWS]

Committed r278121 (238171@main): <https://commits.webkit.org/238171@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429779 [details].

[Radar WebKit Bug Importer]

<rdar://problem/78528218>

[David Kilzer (:ddkilzer)]

(In reply to EWS from comment #5)
> Committed r278121 (238171@main): <https://commits.webkit.org/238171@main>
> 
> All reviewed patches have been landed. Closing bug and clearing flags on
> attachment 429779 [details].

Follow-up build fix for coverage+release builds due to weak external symbol:

    REGRESSION (r278121): Fix build failure due to weak external symbol

Committed r278461 (278461@main): <https://commits.webkit.org/278461@main>

I believe this happened because the weak symbol (DDHighlightCreateWithRectsInVisibleRectWithStyleScaleAndDirection) was added to a second source file:

    Source/WebCore/page/mac/ImageOverlayControllerMac.mm

[Wenson Hsieh]

(In reply to David Kilzer (:ddkilzer) from comment #7)
> (In reply to EWS from comment #5)
> > Committed r278121 (238171@main): <https://commits.webkit.org/238171@main>
> > 
> > All reviewed patches have been landed. Closing bug and clearing flags on
> > attachment 429779 [details].
> 
> Follow-up build fix for coverage+release builds due to weak external symbol:
> 
>     REGRESSION (r278121): Fix build failure due to weak external symbol
> 
> Committed r278461 (278461@main): <https://commits.webkit.org/278461@main>
> 
> I believe this happened because the weak symbol
> (DDHighlightCreateWithRectsInVisibleRectWithStyleScaleAndDirection) was
> added to a second source file:
> 
>     Source/WebCore/page/mac/ImageOverlayControllerMac.mm

Ideally, these would be declared a softlinking header in PAL. I can do this refactoring in a followup.

[Wenson Hsieh]

(In reply to Wenson Hsieh from comment #8)
> (In reply to David Kilzer (:ddkilzer) from comment #7)
> > (In reply to EWS from comment #5)
> > > Committed r278121 (238171@main): <https://commits.webkit.org/238171@main>
> > > 
> > > All reviewed patches have been landed. Closing bug and clearing flags on
> > > attachment 429779 [details].
> > 
> > Follow-up build fix for coverage+release builds due to weak external symbol:
> > 
> >     REGRESSION (r278121): Fix build failure due to weak external symbol
> > 
> > Committed r278461 (278461@main): <https://commits.webkit.org/278461@main>
> > 
> > I believe this happened because the weak symbol
> > (DDHighlightCreateWithRectsInVisibleRectWithStyleScaleAndDirection) was
> > added to a second source file:
> > 
> >     Source/WebCore/page/mac/ImageOverlayControllerMac.mm
> 
> Ideally, these would be declared a softlinking header in PAL. I can do this
> refactoring in a followup.

Doing this in https://bugs.webkit.org/show_bug.cgi?id=226669.