Bug 209788 - Update to new Data Detectors SPI
Summary: Update to new Data Detectors SPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks: 226227
  Show dependency treegraph
 
Reported: 2020-03-30 16:02 PDT by Megan Gardner
Modified: 2021-06-04 08:53 PDT (History)
7 users (show)

See Also:


Attachments
Patch (5.52 KB, patch)
2020-03-30 16:05 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch (5.59 KB, patch)
2020-03-30 16:06 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch (6.31 KB, patch)
2020-03-30 17:24 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch (6.41 KB, patch)
2020-03-30 17:28 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2020-03-30 16:02:42 PDT
Update to new Data Detectors SPI
Comment 1 Megan Gardner 2020-03-30 16:05:05 PDT
Created attachment 394978 [details]
Patch
Comment 2 Megan Gardner 2020-03-30 16:06:11 PDT
Created attachment 394979 [details]
Patch
Comment 3 Megan Gardner 2020-03-30 16:06:36 PDT
<rdar://problem/60690050>
Comment 4 Darin Adler 2020-03-30 16:34:31 PDT
Comment on attachment 394979 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394979&action=review

Is this OK all the way back to Mojave?

> Source/WebCore/page/mac/ServicesOverlayController.mm:519
> +        RetainPtr<DDHighlightRef> ddHighlight = adoptCF(DDHighlightCreateWithRectsInVisibleRectWithStyleScaleAndDirection(nullptr, &cgRect, 1, mainFrameView.visibleContentRect(), DDHighlightStyleBubbleStandard | DDHighlightStyleStandardIconArrow, YES, NSWritingDirectionNatural, NO, YES, 0));

Might be nicer to use auto here.

> Source/WebCore/page/mac/ServicesOverlayController.mm:561
> +            RetainPtr<DDHighlightRef> ddHighlight = adoptCF(DDHighlightCreateWithRectsInVisibleRectWithStyleScaleAndDirection(nullptr, cgRects.begin(), cgRects.size(), visibleRect, DDHighlightStyleBubbleNone | DDHighlightStyleStandardIconArrow | DDHighlightStyleButtonShowAlways, YES, NSWritingDirectionNatural, NO, YES, 0));

Ditto.
Comment 5 Megan Gardner 2020-03-30 17:24:31 PDT
Created attachment 394990 [details]
Patch
Comment 6 Megan Gardner 2020-03-30 17:28:37 PDT
Created attachment 394991 [details]
Patch
Comment 7 EWS 2020-03-30 20:12:17 PDT
Committed r259276: <https://trac.webkit.org/changeset/259276>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394991 [details].