Update to new Data Detectors SPI
Created attachment 394978 [details] Patch
Created attachment 394979 [details] Patch
<rdar://problem/60690050>
Comment on attachment 394979 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394979&action=review Is this OK all the way back to Mojave? > Source/WebCore/page/mac/ServicesOverlayController.mm:519 > + RetainPtr<DDHighlightRef> ddHighlight = adoptCF(DDHighlightCreateWithRectsInVisibleRectWithStyleScaleAndDirection(nullptr, &cgRect, 1, mainFrameView.visibleContentRect(), DDHighlightStyleBubbleStandard | DDHighlightStyleStandardIconArrow, YES, NSWritingDirectionNatural, NO, YES, 0)); Might be nicer to use auto here. > Source/WebCore/page/mac/ServicesOverlayController.mm:561 > + RetainPtr<DDHighlightRef> ddHighlight = adoptCF(DDHighlightCreateWithRectsInVisibleRectWithStyleScaleAndDirection(nullptr, cgRects.begin(), cgRects.size(), visibleRect, DDHighlightStyleBubbleNone | DDHighlightStyleStandardIconArrow | DDHighlightStyleButtonShowAlways, YES, NSWritingDirectionNatural, NO, YES, 0)); Ditto.
Created attachment 394990 [details] Patch
Created attachment 394991 [details] Patch
Committed r259276: <https://trac.webkit.org/changeset/259276> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394991 [details].