Bug 226204 – AX: Fix build failure for WK API WTF::String usage

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

Build failure from 

https://bugs.webkit.org/show_bug.cgi?id=225909#c13

[Radar WebKit Bug Importer]

<rdar://problem/78428840>

[chris fleizach]

Created attachment 429605 [details]
patch

[Tim Horton]

Comment on attachment 429605 [details]
patch

I think the caller of WKAccessibilityTestingInjectPreference in WKTR likely needs to change too

[chris fleizach]

Created attachment 429607 [details]
patch

[Tim Horton]

Comment on attachment 429607 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429607&action=review

> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:105
> +    WKAccessibilityTestingInjectPreference(page, toWKString(context, JSValueMakeString(context, domain)).get(), toWKString(context, JSValueMakeString(context, key)).get(), toWK((String)encodedString).get());

Probably could be WKStringCreateWithJSString

[Darin Adler]

Comment on attachment 429607 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429607&action=review

>> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:105
>> +    WKAccessibilityTestingInjectPreference(page, toWKString(context, JSValueMakeString(context, domain)).get(), toWKString(context, JSValueMakeString(context, key)).get(), toWK((String)encodedString).get());
> 
> Probably could be WKStringCreateWithJSString

instead of:

    toWKString(context, JSValueMakeString(context, domain)).get()

write:

    toWK(domain).get()

As long as you include the header StringFunctions.h. Also should come up with a better way to convert an NSString to a WKString that does not involve converting to (String).

[Darin Adler]

Instead of:

    toWK((String)encodedString).get()

Should use:

    toWK(encodedString.createJSStringRef.get())

As long as we include the header AccessibilityCommonMac.h and StringFunctions.h

[Darin Adler]

Or could add createWKStringRef to the NSString category.

[Darin Adler]

Could name that toWK and overload it for NSString.

[EWS]

Committed r277987 (238100@main): <https://commits.webkit.org/238100@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429607 [details].