Bug 225909 – AX: Settings: Increase contrast isn't detected in browser until an additional setting is applied

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

When using a media query to detect the setting "Increase Contrast" AX setting, the setting can't be detected until an additional setting is updated.

<rdar://problem/77580880>

[chris fleizach]

Created attachment 429143 [details]
patch

[chris fleizach]

Created attachment 429144 [details]
patch

[chris fleizach]

Created attachment 429187 [details]
patch

[chris fleizach]

Created attachment 429188 [details]
patch

[chris fleizach]

Created attachment 429204 [details]
patch

[Per Arne Vollan]

Comment on attachment 429204 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429204&action=review

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:1130
> +    auto cfKey = key.createCFString().get();

I think you may need to retain the CFStringRef here.

auto cfKey = key.createCFString();

[Per Arne Vollan]

Comment on attachment 429204 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429204&action=review

R=me.

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:1074
> +static const WTF::String& invertColorsPreferenceKey()

Is there an existing constant you can use for this key?

[chris fleizach]

Comment on attachment 429204 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429204&action=review

>> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:1074
>> +static const WTF::String& invertColorsPreferenceKey()
> 
> Is there an existing constant you can use for this key?

unfortunately no, I can ask to expose one for the future though (Rdar://78317458)

>> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:1130
>> +    auto cfKey = key.createCFString().get();
> 
> I think you may need to retain the CFStringRef here.
> 
> auto cfKey = key.createCFString();

done

[chris fleizach]

Created attachment 429312 [details]
patch

[chris fleizach]

Created attachment 429313 [details]
patch

[chris fleizach]

Created attachment 429538 [details]
patch

[EWS]

Committed r277971 (238093@main): <https://commits.webkit.org/238093@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429538 [details].

[Tim Horton]

Comment on attachment 429538 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429538&action=review

> Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:99
> +WK_EXPORT void WKAccessibilityTestingInjectPreference(WKBundlePageRef, const String& domain, const String& key, const Optional<String>& encodedValue);

You can't use WTF::String in API; see WKStringRef. This breaks the build (I'm not sure why EWS didn't catch it, but it's failing for other patches now that it's landed).

[chris fleizach]

(In reply to Tim Horton from comment #13)
> Comment on attachment 429538 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=429538&action=review
> 
> > Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:99
> > +WK_EXPORT void WKAccessibilityTestingInjectPreference(WKBundlePageRef, const String& domain, const String& key, const Optional<String>& encodedValue);
> 
> You can't use WTF::String in API; see WKStringRef. This breaks the build
> (I'm not sure why EWS didn't catch it, but it's failing for other patches
> now that it's landed).

Ok will update

[WebKit Commit Bot]

Re-opened since this is blocked by bug 226202

[Truitt Savell]

It looks like the changes in https://trac.webkit.org/changeset/277971/webkit

broke TestWebKitAPI.WebKit.AccessibilityReduceMotion and is now timing out

history:
https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.WebKit.AccessibilityReduceMotion

[chris fleizach]

(In reply to Truitt Savell from comment #16)
> It looks like the changes in https://trac.webkit.org/changeset/277971/webkit
> 
> broke TestWebKitAPI.WebKit.AccessibilityReduceMotion and is now timing out
> 
> history:
> https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.WebKit.
> AccessibilityReduceMotion

Thanks for pointing out. Will take a look at that test. Whatever it was checking wasn’t accurate if it was passing before…

[Truitt Savell]

Filed https://bugs.webkit.org/show_bug.cgi?id=226505