Bug 226119 - Stop using holdLock() in WebCore as it is not compatible with Clang thread safety analysis
Summary: Stop using holdLock() in WebCore as it is not compatible with Clang thread sa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-21 16:09 PDT by Chris Dumez
Modified: 2021-05-24 02:31 PDT (History)
34 users (show)

See Also:


Attachments
Patch (118.44 KB, patch)
2021-05-21 16:11 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (109.61 KB, patch)
2021-05-21 16:52 PDT, Chris Dumez
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (102.43 KB, patch)
2021-05-21 17:04 PDT, Chris Dumez
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (101.01 KB, patch)
2021-05-21 17:08 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (100.57 KB, patch)
2021-05-21 19:07 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-05-21 16:09:30 PDT
Stop using holdLock() in WebCore as it is not compatible with Clang thread safety analysis.
Comment 1 Chris Dumez 2021-05-21 16:11:27 PDT
Created attachment 429357 [details]
Patch
Comment 2 Chris Dumez 2021-05-21 16:52:18 PDT
Created attachment 429365 [details]
Patch
Comment 3 Chris Dumez 2021-05-21 17:04:18 PDT
Created attachment 429367 [details]
Patch
Comment 4 Chris Dumez 2021-05-21 17:08:12 PDT
Created attachment 429370 [details]
Patch
Comment 5 Sam Weinig 2021-05-21 18:31:29 PDT
Comment on attachment 429370 [details]
Patch

Nice.
Comment 6 EWS 2021-05-21 18:54:21 PDT
Tools/Scripts/svn-apply failed to apply attachment 429370 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 7 Chris Dumez 2021-05-21 19:07:54 PDT
Created attachment 429386 [details]
Patch
Comment 8 EWS 2021-05-21 20:04:35 PDT
Committed r277908 (238041@main): <https://commits.webkit.org/238041@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429386 [details].
Comment 9 Radar WebKit Bug Importer 2021-05-21 20:05:18 PDT
<rdar://problem/78340445>