WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
226116
Stop using holdLock() in JSC as it is not compatible with Clang thread safety analysis
https://bugs.webkit.org/show_bug.cgi?id=226116
Summary
Stop using holdLock() in JSC as it is not compatible with Clang thread safety...
Chris Dumez
Reported
2021-05-21 15:36:09 PDT
Stop using holdLock() in JSC as it is not compatible with Clang thread safety analysis (CheckedLock). Use the Locker constructor instead.
Attachments
Patch
(137.40 KB, patch)
2021-05-21 15:38 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2021-05-21 15:38:29 PDT
Created
attachment 429353
[details]
Patch
Mark Lam
Comment 2
2021-05-21 16:18:34 PDT
Comment on
attachment 429353
[details]
Patch r=me if EWS bots are happy.
EWS
Comment 3
2021-05-21 20:13:26 PDT
Committed
r277909
(
238042@main
): <
https://commits.webkit.org/238042@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 429353
[details]
.
Radar WebKit Bug Importer
Comment 4
2021-05-21 20:14:18 PDT
<
rdar://problem/78340630
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug