Bug 226116 - Stop using holdLock() in JSC as it is not compatible with Clang thread safety analysis
Summary: Stop using holdLock() in JSC as it is not compatible with Clang thread safety...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-21 15:36 PDT by Chris Dumez
Modified: 2021-05-21 20:14 PDT (History)
11 users (show)

See Also:

Attachments
Patch (137.40 KB, patch)
2021-05-21 15:38 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-05-21 15:36:09 PDT 
Stop using holdLock() in JSC as it is not compatible with Clang thread safety analysis (CheckedLock). Use the Locker constructor instead.
Comment 1 Chris Dumez 2021-05-21 15:38:29 PDT 
Created attachment 429353 [details]
Patch
Comment 2 Mark Lam 2021-05-21 16:18:34 PDT 
Comment on attachment 429353 [details]
Patch

r=me if EWS bots are happy.
Comment 3 EWS 2021-05-21 20:13:26 PDT 
Committed r277909 (238042@main): <https://commits.webkit.org/238042@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429353 [details].
Comment 4 Radar WebKit Bug Importer 2021-05-21 20:14:18 PDT 
<rdar://problem/78340630>