Bug 225486 - Retry asynchronously in WebProcessPool::getGPUProcessConnection() in case of failure
Summary: Retry asynchronously in WebProcessPool::getGPUProcessConnection() in case of ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-06 15:02 PDT by Chris Dumez
Modified: 2021-05-06 18:50 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.13 KB, patch)
2021-05-06 15:04 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (3.13 KB, patch)
2021-05-06 16:52 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-05-06 15:02:23 PDT
Retry asynchronously in WebProcessPool::getGPUProcessConnection(), similarly to what we do in WebsiteDataStore::getNetworkProcessConnection(). As a result, we no longer need to ref the WebProcessPool in the lambda and we avoid retrying unnecessarily when the WebProcessPool is getting destroyed.
Comment 1 Chris Dumez 2021-05-06 15:04:18 PDT
Created attachment 427939 [details]
Patch
Comment 2 Chris Dumez 2021-05-06 16:52:05 PDT
Created attachment 427959 [details]
Patch
Comment 3 EWS 2021-05-06 18:49:01 PDT
Committed r277151 (237438@main): <https://commits.webkit.org/237438@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427959 [details].
Comment 4 Radar WebKit Bug Importer 2021-05-06 18:50:16 PDT
<rdar://problem/77636072>