Bug 225478 - Fix crash when WebsiteDataStore is destroyed with outstanding getNetworkProcessConnection request
Summary: Fix crash when WebsiteDataStore is destroyed with outstanding getNetworkProce...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-06 13:13 PDT by Alex Christensen
Modified: 2021-05-06 15:02 PDT (History)
2 users (show)

See Also:


Attachments
Patch (3.63 KB, patch)
2021-05-06 13:19 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (3.73 KB, patch)
2021-05-06 13:24 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-05-06 13:13:36 PDT
Fix crash when WebsiteDataStore is destroyed with outstanding getNetworkProcessConnection request
Comment 1 Alex Christensen 2021-05-06 13:19:35 PDT
Created attachment 427926 [details]
Patch
Comment 2 Alex Christensen 2021-05-06 13:19:38 PDT
<rdar://problem/77576148>
Comment 3 Chris Dumez 2021-05-06 13:22:03 PDT
Comment on attachment 427926 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427926&action=review

r=me

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1725
> +            RunLoop::main().dispatch([weakThis = WTFMove(weakThis), webProcessProxy = WTFMove(webProcessProxy), reply = WTFMove(reply)] () mutable {

We may want to add a comment explaining we're retrying asynchronously because we may be in the middle of destruction.
Comment 4 Alex Christensen 2021-05-06 13:24:09 PDT
Created attachment 427927 [details]
Patch
Comment 5 Alex Christensen 2021-05-06 13:41:04 PDT
r277114