Bug 225332 - REGRESSION (r276883): [Debug] ASSERTION FAILED: index != notFound in WebCore::PlatformMediaSessionManager::setCurrentSession()
Summary: REGRESSION (r276883): [Debug] ASSERTION FAILED: index != notFound in WebCore:...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
Keywords: InRadar
Depends on:
Reported: 2021-05-03 15:49 PDT by Truitt Savell
Modified: 2021-05-04 12:29 PDT (History)
13 users (show)

See Also:

crash log (125.48 KB, text/plain)
2021-05-03 16:44 PDT, Ryan Haddad
no flags Details
Patch (2.92 KB, patch)
2021-05-04 08:59 PDT, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Truitt Savell 2021-05-03 15:49:25 PDT

This test began crashing with the changes in https://trac.webkit.org/changeset/276883/webkit


Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.JavaScriptCore      	0x000000065a2a73be WTFCrash + 14 (Assertions.cpp:305)
1   com.apple.WebCore             	0x0000000639610eeb WTFCrashWithInfo(int, char const*, char const*, int) + 27 (Assertions.h:695)
2   com.apple.WebCore             	0x000000063dab1dd5 WebCore::PlatformMediaSessionManager::setCurrentSession(WebCore::PlatformMediaSession&) + 293 (PlatformMediaSessionManager.cpp:312)
3   com.apple.WebCore             	0x000000063b1764b7 WebCore::MediaSessionManagerCocoa::setCurrentSession(WebCore::PlatformMediaSession&) + 39 (MediaSessionManagerCocoa.mm:213)

Comment 1 Radar WebKit Bug Importer 2021-05-03 15:49:43 PDT
Comment 2 Ryan Haddad 2021-05-03 16:44:53 PDT
Created attachment 427616 [details]
crash log

ASSERTION FAILED: index != notFound
./platform/audio/PlatformMediaSessionManager.cpp(312) : virtual void WebCore::PlatformMediaSessionManager::setCurrentSession(WebCore::PlatformMediaSession &)
Comment 3 Jer Noble 2021-05-03 17:50:57 PDT
Yep, caused by r276883. I'm super curious how this wasn't hit by the EWS bots though.
Comment 4 Jer Noble 2021-05-03 17:51:37 PDT
The session is setActive(true) immediately after the ASSERT. Looks like we need to move up the activation by a couple lines.
Comment 5 Jer Noble 2021-05-04 08:59:09 PDT
Created attachment 427672 [details]
Comment 6 EWS 2021-05-04 12:29:40 PDT
Committed r276978 (237305@main): <https://commits.webkit.org/237305@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427672 [details].