Bug 225162 – Stop building libANGLE.a

• Status: RESOLVED
• Resolution: FIXED
• Component: ANGLE

[Alex Christensen]

Stop building libANGLE.a

[Alex Christensen]

Created attachment 427291 [details]
Patch

[Alex Christensen]

<rdar://problem/57349384>

[EWS Watchlist]

Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE

[Alexey Proskuryakov]

Comment on attachment 427291 [details]
Patch

I have no idea why this has so many green (added) lines, but rs=me I guess?..

[EWS]

Committed r276734 (237135@main): <https://commits.webkit.org/237135@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427291 [details].

[David Kilzer (:ddkilzer)]

(In reply to Alexey Proskuryakov from comment #4)
> Comment on attachment 427291 [details]
> Patch
> 
> I have no idea why this has so many green (added) lines, but rs=me I guess?..

It’s because we were using a trick to link the static library (libANGLE.a) with empty.o to create the dynamic library so we only had to compile the sources once.

When the static library target was removed, the compiled sources had to move from the static library target to the dynamic library target.

[David Kilzer (:ddkilzer)]

(In reply to David Kilzer (:ddkilzer) from comment #6)
> (In reply to Alexey Proskuryakov from comment #4)
> > Comment on attachment 427291 [details]
> > Patch
> > 
> > I have no idea why this has so many green (added) lines, but rs=me I guess?..
> 
> It’s because we were using a trick to link the static library (libANGLE.a)
> with empty.o to create the dynamic library so we only had to compile the
> sources once.
> 
> When the static library target was removed, the compiled sources had to move
> from the static library target to the dynamic library target.

See:  <https://bugs.webkit.org/show_bug.cgi?id=218469>