Bug 218469 - Stop building ANGLE source files twice
Summary: Stop building ANGLE source files twice
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
Keywords: InRadar
Depends on:
Reported: 2020-11-02 16:39 PST by David Kilzer (:ddkilzer)
Modified: 2021-04-29 06:47 PDT (History)
7 users (show)

See Also:

Patch v1 (84.38 KB, patch)
2020-11-02 16:53 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2020-11-02 16:39:31 PST
Stop building ANGLE source files twice.

We can build libANGLE.a first, and then use it to link libANGLE-shared.dylib.
Comment 1 David Kilzer (:ddkilzer) 2020-11-02 16:53:54 PST
Created attachment 412989 [details]
Patch v1
Comment 2 EWS Watchlist 2020-11-02 16:54:37 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 David Kilzer (:ddkilzer) 2020-11-02 16:59:48 PST
(In reply to David Kilzer (:ddkilzer) from comment #1)
> Created attachment 412989 [details]
> Patch v1

I verified that the symbols are identical in libANGLE-shared.dyilb before/after this change.
Comment 4 EWS 2020-11-03 10:46:06 PST
Committed r269315: <https://trac.webkit.org/changeset/269315>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412989 [details].
Comment 5 Radar WebKit Bug Importer 2020-11-03 10:47:44 PST