Bug 225041 - Add an option to not enable all experimental features in DumpRenderTree
Summary: Add an option to not enable all experimental features in DumpRenderTree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on: 224958
Blocks:
  Show dependency tree / graph
 
Reported: 2021-04-25 19:11 PDT by Ryosuke Niwa
Modified: 2021-04-25 22:52 PDT (History)
2 users (show)

See Also:

Attachments
Adds a flag (2.75 KB, patch)
2021-04-25 19:13 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2021-04-25 19:11:16 PDT 
We need an option to avoid enabling all experimental features in DumpRenderTree
so that we can run tests with the set of features we're intending to ship / are stable.
Comment 1 Ryosuke Niwa 2021-04-25 19:13:12 PDT 
Created attachment 427018 [details]
Adds a flag
Comment 2 Wenson Hsieh 2021-04-25 19:15:35 PDT 
Comment on attachment 427018 [details]
Adds a flag

View in context: https://bugs.webkit.org/attachment.cgi?id=427018&action=review

r=mews

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:273
> +static int enableAllExperimentalFeatures = YES;

Nit - BOOL?
Comment 3 Ryosuke Niwa 2021-04-25 19:54:42 PDT 
Comment on attachment 427018 [details]
Adds a flag

View in context: https://bugs.webkit.org/attachment.cgi?id=427018&action=review

>> Tools/DumpRenderTree/mac/DumpRenderTree.mm:273
>> +static int enableAllExperimentalFeatures = YES;
> 
> Nit - BOOL?

I think getopt_long wants these to be int's, not bool's.
Comment 4 Ryosuke Niwa 2021-04-25 22:51:26 PDT 
Comment on attachment 427018 [details]
Adds a flag

Clearing flags on attachment: 427018

Committed r276581 (237017@main): <https://commits.webkit.org/237017@main>
Comment 5 Ryosuke Niwa 2021-04-25 22:51:28 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2021-04-25 22:52:19 PDT 
<rdar://problem/77138402>