We need an option to avoid enabling all experimental features in WebKitTestRunner so that we can run tests with the set of features we're intending to ship / are stable.
Created attachment 426865 [details] Patch
Comment on attachment 426865 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426865&action=review > Tools/WebKitTestRunner/TestController.h:542 > + bool m_enableAllExperimentalFeatures { false }; Humorous and confusing that the default is different here (I assume it gets plumbed from Options?)
Comment on attachment 426865 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426865&action=review >> Tools/WebKitTestRunner/TestController.h:542 >> + bool m_enableAllExperimentalFeatures { false }; > > Humorous and confusing that the default is different here (I assume it gets plumbed from Options?) Yup. I'd change the default to true for consistency.
Created attachment 426872 [details] Patch for landing
Comment on attachment 426872 [details] Patch for landing Wait for EWS.
Comment on attachment 426872 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=426872&action=review > Source/WebKit/ChangeLog:8 > + Added a helper SPI to reset the runtime flags of all experimental features. I don't think this is needed. We already reset everything between tests. Just don't enable the experimental features if you don't want them enable.
(In reply to Sam Weinig from comment #6) > Comment on attachment 426872 [details] > Patch for landing > > View in context: > https://bugs.webkit.org/attachment.cgi?id=426872&action=review > > > Source/WebKit/ChangeLog:8 > > + Added a helper SPI to reset the runtime flags of all experimental features. > > I don't think this is needed. We already reset everything between tests. > Just don't enable the experimental features if you don't want them enable. Oh, you're right. Will revert this part before landing.
Created attachment 426992 [details] Patch for landing
Committed r276559 (236996@main): <https://commits.webkit.org/236996@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426992 [details].
<rdar://problem/77111442>