Bug 224958 - Add an option to not enable all experimental features in WebKitTestRunner
Summary: Add an option to not enable all experimental features in WebKitTestRunner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks: 225041
  Show dependency treegraph
 
Reported: 2021-04-22 16:53 PDT by Ryosuke Niwa
Modified: 2021-04-25 19:11 PDT (History)
9 users (show)

See Also:


Attachments
Patch (11.89 KB, patch)
2021-04-22 16:59 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Patch for landing (12.85 KB, patch)
2021-04-22 17:19 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Patch for landing (8.52 KB, patch)
2021-04-24 17:13 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2021-04-22 16:53:31 PDT
We need an option to avoid enabling all experimental features in WebKitTestRunner
so that we can run tests with the set of features we're intending to ship / are stable.
Comment 1 Ryosuke Niwa 2021-04-22 16:59:16 PDT
Created attachment 426865 [details]
Patch
Comment 2 Tim Horton 2021-04-22 17:05:48 PDT
Comment on attachment 426865 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426865&action=review

> Tools/WebKitTestRunner/TestController.h:542
> +    bool m_enableAllExperimentalFeatures { false };

Humorous and confusing that the default is different here (I assume it gets plumbed from Options?)
Comment 3 Ryosuke Niwa 2021-04-22 17:12:07 PDT
Comment on attachment 426865 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426865&action=review

>> Tools/WebKitTestRunner/TestController.h:542
>> +    bool m_enableAllExperimentalFeatures { false };
> 
> Humorous and confusing that the default is different here (I assume it gets plumbed from Options?)

Yup. I'd change the default to true for consistency.
Comment 4 Ryosuke Niwa 2021-04-22 17:19:48 PDT
Created attachment 426872 [details]
Patch for landing
Comment 5 Ryosuke Niwa 2021-04-22 17:20:19 PDT
Comment on attachment 426872 [details]
Patch for landing

Wait for EWS.
Comment 6 Sam Weinig 2021-04-22 17:37:03 PDT
Comment on attachment 426872 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=426872&action=review

> Source/WebKit/ChangeLog:8
> +        Added a helper SPI to reset the runtime flags of all experimental features.

I don't think this is needed. We already reset everything between tests. Just don't enable the experimental features if you don't want them enable.
Comment 7 Ryosuke Niwa 2021-04-24 17:05:28 PDT
(In reply to Sam Weinig from comment #6)
> Comment on attachment 426872 [details]
> Patch for landing
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=426872&action=review
> 
> > Source/WebKit/ChangeLog:8
> > +        Added a helper SPI to reset the runtime flags of all experimental features.
> 
> I don't think this is needed. We already reset everything between tests.
> Just don't enable the experimental features if you don't want them enable.

Oh, you're right. Will revert this part before landing.
Comment 8 Ryosuke Niwa 2021-04-24 17:13:26 PDT
Created attachment 426992 [details]
Patch for landing
Comment 9 EWS 2021-04-24 17:39:52 PDT
Committed r276559 (236996@main): <https://commits.webkit.org/236996@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426992 [details].
Comment 10 Radar WebKit Bug Importer 2021-04-24 17:40:15 PDT
<rdar://problem/77111442>