WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
224663
[WPE][GTK] Enable AVIF decoder as experimental feature and unskip tests
https://bugs.webkit.org/show_bug.cgi?id=224663
Summary
[WPE][GTK] Enable AVIF decoder as experimental feature and unskip tests
Philippe Normand
Reported
2021-04-16 03:30:23 PDT
I've started a patch.
Attachments
Patch
(9.53 KB, patch)
2021-04-16 03:51 PDT
,
Philippe Normand
no flags
Details
Formatted Diff
Diff
[fast-cq] Patch
(12.13 KB, patch)
2021-04-17 09:59 PDT
,
Philippe Normand
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Philippe Normand
Comment 1
2021-04-16 03:51:16 PDT
Created
attachment 426205
[details]
Patch
Xabier Rodríguez Calvar
Comment 2
2021-04-16 08:01:15 PDT
Comment on
attachment 426205
[details]
Patch LGTM but you might want some more comments other than mine.
Michael Catanzaro
Comment 3
2021-04-17 06:32:26 PDT
Comment on
attachment 426205
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=426205&action=review
> Source/cmake/OptionsGTK.cmake:84 > +WEBKIT_OPTION_DEFINE(USE_AVIF "Whether to enable support for AVIF images." PUBLIC ${ENABLE_EXPERIMENTAL_FEATURES})
Alphabetize please ;)
> Source/cmake/OptionsWPE.cmake:80 > +WEBKIT_OPTION_DEFINE(USE_AVIF "Whether to enable support for AVIF images." PUBLIC ${ENABLE_EXPERIMENTAL_FEATURES})
Ditto, they're all alphabetized except ENABLE_WPE_QT_API
Philippe Normand
Comment 4
2021-04-17 09:59:49 PDT
Created
attachment 426334
[details]
[fast-cq] Patch
EWS
Comment 5
2021-04-19 01:03:05 PDT
commit-queue failed to commit
attachment 426334
[details]
to WebKit repository. To retry, please set cq+ flag again.
EWS
Comment 6
2021-04-19 01:09:51 PDT
commit-queue failed to commit
attachment 426334
[details]
to WebKit repository. To retry, please set cq+ flag again.
Philippe Normand
Comment 7
2021-04-19 01:17:04 PDT
Committed
r276238
(
236720@main
): <
https://commits.webkit.org/236720@main
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug