Bug 224663 - [WPE][GTK] Enable AVIF decoder as experimental feature and unskip tests
Summary: [WPE][GTK] Enable AVIF decoder as experimental feature and unskip tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-16 03:30 PDT by Philippe Normand
Modified: 2021-04-19 01:17 PDT (History)
10 users (show)

See Also:


Attachments
Patch (9.53 KB, patch)
2021-04-16 03:51 PDT, Philippe Normand
no flags Details | Formatted Diff | Diff
[fast-cq] Patch (12.13 KB, patch)
2021-04-17 09:59 PDT, Philippe Normand
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2021-04-16 03:30:23 PDT
I've started a patch.
Comment 1 Philippe Normand 2021-04-16 03:51:16 PDT
Created attachment 426205 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2021-04-16 08:01:15 PDT
Comment on attachment 426205 [details]
Patch

LGTM but you might want some more comments other than mine.
Comment 3 Michael Catanzaro 2021-04-17 06:32:26 PDT
Comment on attachment 426205 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426205&action=review

> Source/cmake/OptionsGTK.cmake:84
> +WEBKIT_OPTION_DEFINE(USE_AVIF "Whether to enable support for AVIF images." PUBLIC ${ENABLE_EXPERIMENTAL_FEATURES})

Alphabetize please ;)

> Source/cmake/OptionsWPE.cmake:80
> +WEBKIT_OPTION_DEFINE(USE_AVIF "Whether to enable support for AVIF images." PUBLIC ${ENABLE_EXPERIMENTAL_FEATURES})

Ditto, they're all alphabetized except ENABLE_WPE_QT_API
Comment 4 Philippe Normand 2021-04-17 09:59:49 PDT
Created attachment 426334 [details]
[fast-cq] Patch
Comment 5 EWS 2021-04-19 01:03:05 PDT
commit-queue failed to commit attachment 426334 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 6 EWS 2021-04-19 01:09:51 PDT
commit-queue failed to commit attachment 426334 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 7 Philippe Normand 2021-04-19 01:17:04 PDT
Committed r276238 (236720@main): <https://commits.webkit.org/236720@main>