Bug 224343 - REGRESSION (r275150): set-webkit-configuration is too aggressive at deleting config files when coverage/sanitizer switch is not set
Summary: REGRESSION (r275150): set-webkit-configuration is too aggressive at deleting ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 176131
Blocks:
  Show dependency tree / graph
 
Reported: 2021-04-08 15:26 PDT by David Kilzer (:ddkilzer)
Modified: 2021-04-08 16:05 PDT (History)
2 users (show)

See Also:

Attachments
Patch v1 (3.07 KB, patch)
2021-04-08 15:30 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2021-04-08 15:26:08 PDT 
The set-webkit-configuration is too aggressive at deleting config files when coverage/sanitizer switch is not set.

This regressed in r275150 for Bug 176131.

See also Bug 224009, which fixed the non-coverage/non-sanitizer switches.
Comment 1 David Kilzer (:ddkilzer) 2021-04-08 15:30:08 PDT 
Created attachment 425549 [details]
Patch v1
Comment 2 Mark Lam 2021-04-08 15:40:45 PDT 
Comment on attachment 425549 [details]
Patch v1

r=me
Comment 3 David Kilzer (:ddkilzer) 2021-04-08 16:01:09 PDT 
Comment on attachment 425549 [details]
Patch v1

Marking cq+ since all build queues have finished building.
Comment 4 EWS 2021-04-08 16:04:53 PDT 
Committed r275686 (236320@main): <https://commits.webkit.org/236320@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425549 [details].
Comment 5 Radar WebKit Bug Importer 2021-04-08 16:05:15 PDT 
<rdar://problem/76426292>