Bug 224009 - REGRESSION (r275150): set-webkit-configuration is too aggressive at deleting config files when switch is not set
Summary: REGRESSION (r275150): set-webkit-configuration is too aggressive at deleting ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 176131
Blocks:
  Show dependency tree / graph
 
Reported: 2021-03-31 12:23 PDT by David Kilzer (:ddkilzer)
Modified: 2021-04-08 15:26 PDT (History)
2 users (show)

See Also:

Attachments
Patch v1 (2.72 KB, patch)
2021-03-31 12:28 PDT, David Kilzer (:ddkilzer) 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2021-03-31 12:23:22 PDT 
The set-webkit-configuration is too aggressive at deleting config files when switch is not set.

This regressed in r275150 for Bug 176131.
Comment 1 David Kilzer (:ddkilzer) 2021-03-31 12:28:08 PDT 
Created attachment 424799 [details]
Patch v1
Comment 2 David Kilzer (:ddkilzer) 2021-03-31 12:42:52 PDT 
Comment on attachment 424799 [details]
Patch v1

Marking cq+ because enough builds have succeeded that I don't think I made the situation any worse, and I want to get this landed sooner rather than later.  (I also compared this patch to set-webkit-configuration from r275150 and the subroutines I restored were unchanged as expected.)
Comment 3 EWS 2021-03-31 13:36:16 PDT 
Committed r275305: <https://commits.webkit.org/r275305>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424799 [details].
Comment 4 Radar WebKit Bug Importer 2021-03-31 13:37:13 PDT 
<rdar://problem/76068475>