Bug 224321 - PCM: Find a way to validate source_secret_token and source_secret_token_signature
Summary: PCM: Find a way to validate source_secret_token and source_secret_token_signa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks: 221291
  Show dependency tree / graph
 
Reported: 2021-04-08 03:49 PDT by Jiewen Tan
Modified: 2021-05-04 17:42 PDT (History)
3 users (show)

See Also:

Attachments
Patch (10.26 KB, patch)
2021-05-04 13:49 PDT, Jiewen Tan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2021-04-08 03:49:27 PDT 
Find a way to validate source_secret_token and source_secret_token_signature.
Comment 1 Radar WebKit Bug Importer 2021-04-15 03:50:13 PDT 
<rdar://problem/76695542>
Comment 2 Jiewen Tan 2021-05-04 13:49:51 PDT 
Created attachment 427695 [details]
Patch
Comment 3 John Wilander 2021-05-04 17:28:16 PDT 
Comment on attachment 427695 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427695&action=review

r=me

> Source/WebKit/ChangeLog:9
> +        Covered by exisiting tests.

Not really. This is expanding the test. :) No big deal though.
Comment 4 Jiewen Tan 2021-05-04 17:32:30 PDT 
Comment on attachment 427695 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427695&action=review

Thanks John for r+ this patch.

>> Source/WebKit/ChangeLog:9
>> +        Covered by exisiting tests.
> 
> Not really. This is expanding the test. :) No big deal though.

Well, the change in WebKit specifically is covered by existing tests. : )
Comment 5 EWS 2021-05-04 17:42:23 PDT 
Committed r276998 (237318@main): <https://commits.webkit.org/237318@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427695 [details].