Bug 224227 – .gitignore contains 'build/' which causes all directories named 'build/' to be ignored

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Kimmo Kinnunen]

.gitignore contains 'build/' which causes all directories named 'build/' to be ignored

* Has caused some WebGL tests to be missing and untested for multiple years.
** Has caused ANGLE METAL backend implementation to contain crashes that would have been caught by the tests.

[Kimmo Kinnunen]

Created attachment 425247 [details]
Patch

[Kimmo Kinnunen]

https://git-scm.com/docs/gitignore

> If there is a separator at the beginning or middle (or both) of the pattern, then the pattern is relative to the directory level of the particular .gitignore file itself. Otherwise the pattern may also match at any level below the .gitignore level.





I think all these are intended to be here, if some of them are intended:

find . -iname 'build' 

./LayoutTests/webgl/1.0.3/resources/webgl_test_files/conformance/ogles/GL/build
./PerformanceTests/Speedometer/resources/todomvc/labs/architecture-examples/react/bower_components/director/build
./PerformanceTests/Speedometer/resources/todomvc/architecture-examples/vuejs-cli/build
./PerformanceTests/Speedometer/resources/todomvc/architecture-examples/react/node_modules/director/build
./Websites/browserbench.org/Speedometer2.0/resources/todomvc/labs/architecture-examples/react/bower_components/director/build
./Websites/browserbench.org/Speedometer2.0/resources/todomvc/architecture-examples/vuejs-cli/build
./Websites/browserbench.org/Speedometer2.0/resources/todomvc/architecture-examples/react/node_modules/director/build

Since there was an explicit non-ignore pattern for one of these directories, I assume this intention is just missing for the other one by mistake.

[Ryosuke Niwa]

Comment on attachment 425247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425247&action=review

> .gitignore:7
> +/build/

I think we should just get rid of this line.
This was relevant 11 years ago (https://trac.webkit.org/r50325).
If I recall correctly, chromium back then used "build" directory.
I don't believe we have any port that adds build directory anymore.

[Kimmo Kinnunen]

Created attachment 425249 [details]
Patch

[EWS]

/Volumes/Data/worker/Commit-Queue/build/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

[Kimmo Kinnunen]

Created attachment 425378 [details]
Patch

[EWS]

Committed r275601: <https://commits.webkit.org/r275601>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425378 [details].

[Radar WebKit Bug Importer]

<rdar://problem/76335650>