Bug 224056 - Share same code between network process termination and crash handling
Summary: Share same code between network process termination and crash handling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-01 10:25 PDT by Chris Dumez
Modified: 2021-04-01 15:28 PDT (History)
5 users (show)

See Also:

Attachments
Patch (9.49 KB, patch)
2021-04-01 10:30 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-04-01 10:25:17 PDT 
Share same code between network process termination and crash handling. This would avoid bugs such as Bug 224022.
Comment 1 Chris Dumez 2021-04-01 10:30:03 PDT 
Created attachment 424911 [details]
Patch
Comment 2 Alex Christensen 2021-04-01 11:59:17 PDT 
Comment on attachment 424911 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424911&action=review

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:-1745
> -        processPool->terminateServiceWorkers();

Does this have a replacement?
Comment 3 Chris Dumez 2021-04-01 12:01:06 PDT 
Comment on attachment 424911 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424911&action=review

> Source/WebKit/UIProcess/WebProcessPool.cpp:484
>          m_automationSession->terminate();

Yes, networkProcessDidTerminate() gets called on termination now and terminates the service workers 2 lines below here.
Comment 4 EWS 2021-04-01 15:27:25 PDT 
Committed r275389: <https://commits.webkit.org/r275389>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424911 [details].
Comment 5 Radar WebKit Bug Importer 2021-04-01 15:28:14 PDT 
<rdar://problem/76124951>