Bug 224022 - REGRESSION: The NetworkProcess sometimes fails to relaunch after it crashes
Summary: REGRESSION: The NetworkProcess sometimes fails to relaunch after it crashes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-31 15:09 PDT by Chris Dumez
Modified: 2021-04-01 10:25 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.09 KB, patch)
2021-03-31 15:15 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-03-31 15:09:33 PDT 
The NetworkProcess fails to relaunch after it crashes. This is a regression from using a NetworkProcess per ProcessPool to a NetworkProcess per WebsiteDataStore AFAICT.
Comment 1 Chris Dumez 2021-03-31 15:09:52 PDT 
<rdar://75148724>
Comment 2 Chris Dumez 2021-03-31 15:15:12 PDT 
Created attachment 424827 [details]
Patch
Comment 3 Alex Christensen 2021-03-31 15:22:55 PDT 
Comment on attachment 424827 [details]
Patch

didTerminate does this too.
Comment 4 Chris Dumez 2021-03-31 15:25:27 PDT 
(In reply to Alex Christensen from comment #3)
> Comment on attachment 424827 [details]
> Patch
> 
> didTerminate does this too.

Indeed, I think the termination and crash logic should share code. I opted not to do it in this patch so to keep the patch small as possible for cherry-picking. Also, there are things the crash handling does and that the termination handling doesn't, which seems like another issue.
Comment 5 Chris Dumez 2021-03-31 15:28:42 PDT 
Comment on attachment 424827 [details]
Patch

I will work in a follow-up to share more code between the termination and crash logic.
Comment 6 EWS 2021-03-31 16:19:54 PDT 
Committed r275316: <https://commits.webkit.org/r275316>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424827 [details].