Bug 223826 – REGRESSION (r275038?): Perf test IndexedDB/stress/large-binary-keys.html failing with logging about memory pressure events

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryan Haddad]

REGRESSION: Catalina-Release-WK2-Perf tests failing with logging about memory pressure events:

Running IndexedDB/stress/large-binary-keys.html (98 of 207)
error: IndexedDB/stress/large-binary-keys.html
Received memory pressure event 16 vm pressure 0
Received memory pressure event 32 vm pressure 0
FAILED
Finished: 208.580084 s

https://build.webkit.org/#/builders/20/builds/416

[Radar WebKit Bug Importer]

<rdar://problem/75906134>

[Ryan Haddad]

https://trac.webkit.org/changeset/275038/webkit looks like it could have been related

[Chris Dumez]

Created attachment 424418 [details]
Patch

[Darin Adler]

Comment on attachment 424418 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424418&action=review

> Source/WTF/ChangeLog:10
> +        Use RELEASE_LOG() instead of WTFLogAlways() to log memory pressure events, so that they don't
> +        show on stdout in the performance tests and make them fail.

Does this still achieve what we want in production builds?

[Chris Dumez]

(In reply to Darin Adler from comment #4)
> Comment on attachment 424418 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=424418&action=review
> 
> > Source/WTF/ChangeLog:10
> > +        Use RELEASE_LOG() instead of WTFLogAlways() to log memory pressure events, so that they don't
> > +        show on stdout in the performance tests and make them fail.
> 
> Does this still achieve what we want in production builds?

We will see the logging is os_log which I believe is suitable for such logging.

[EWS]

Committed r275125: <https://commits.webkit.org/r275125>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424418 [details].