Bug 223764 - Simplify IPCSemaphore.h
Summary: Simplify IPCSemaphore.h
Status: RESOLVED DUPLICATE of bug 224014
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-25 14:59 PDT by Myles C. Maxfield
Modified: 2021-04-06 10:14 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.06 KB, patch)
2021-03-25 15:00 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-03-25 14:59:52 PDT 
Simplify IPCSemaphore.h
Comment 1 Myles C. Maxfield 2021-03-25 15:00:48 PDT 
Created attachment 424285 [details]
Patch
Comment 2 Geoffrey Garen 2021-03-29 13:16:50 PDT 
Comment on attachment 424285 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424285&action=review

> Source/WebKit/Platform/IPC/IPCSemaphore.h:62
> -#if OS(DARWIN)
> -    explicit Semaphore(MachSendRight&&);
> -
>      void signal();
>      void wait();
>      void waitFor(Timeout);
> +
> +    explicit operator bool() const;
> +
> +#if OS(DARWIN)
> +    explicit Semaphore(MachSendRight&&);

Is there a non-Darwin implementation of signal(), wait(), and waitFor()? I don't see one in IPCSemaphore.cpp.
Comment 3 Radar WebKit Bug Importer 2021-04-01 15:00:15 PDT 
<rdar://problem/76123506>
Comment 4 Myles C. Maxfield 2021-04-06 10:14:18 PDT 

*** This bug has been marked as a duplicate of bug 224014 ***