Bug 224223 - Add IPC::Semaphore stub for Unix ports
Summary: Add IPC::Semaphore stub for Unix ports
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-05 22:13 PDT by Fujii Hironori
Modified: 2021-04-06 14:28 PDT (History)
14 users (show)

See Also:


Attachments
Patch (27.40 KB, patch)
2021-04-05 22:19 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff
Patch for landing (25.17 KB, patch)
2021-04-06 13:04 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2021-04-05 22:13:22 PDT
Add IPC::Semaphore stub for Unix ports
Comment 1 Fujii Hironori 2021-04-05 22:19:26 PDT
Created attachment 425242 [details]
Patch
Comment 2 Kimmo Kinnunen 2021-04-05 22:45:18 PDT
Does the "scattering of ifdefs" have a substantial problem in context of WebKit, where ifdefs are used in general?
I think the original intention was that the code "sort-of works" without the semaphore. So this takes it to "definitively does not work". Not that this choice would be bad, it may be better than what's currently in..
Comment 3 Fujii Hironori 2021-04-05 23:43:48 PDT
Yes, it seems the original intention. However, it didn't work as far as I tested. 
Unused code will become broken quickly. Sooner or later, Unix ports also should have the semaphore implementation.
Comment 4 Kimmo Kinnunen 2021-04-05 23:59:32 PDT
> However, it didn't work as far as I tested.  Unused code will become broken quickly. 

Sounds like a good rationale.

> Sooner or later, Unix ports also should have the semaphore implementation.

Great!
Comment 5 Fujii Hironori 2021-04-06 13:04:54 PDT
Created attachment 425314 [details]
Patch for landing
Comment 6 Fujii Hironori 2021-04-06 14:27:26 PDT
Comment on attachment 425314 [details]
Patch for landing

Clearing flags on attachment: 425314

Committed r275553 (236209@main): <https://commits.webkit.org/236209@main>
Comment 7 Fujii Hironori 2021-04-06 14:27:30 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2021-04-06 14:28:24 PDT
<rdar://problem/76284505>