Bug 223317 - webgl/1.0.x/conformance/glsl/misc/fragcolor-fragdata-invariant.html fails
Summary: webgl/1.0.x/conformance/glsl/misc/fragcolor-fragdata-invariant.html fails
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
Keywords: InRadar
: 223334 (view as bug list)
Depends on:
Blocks: webgl2conformance
  Show dependency treegraph
Reported: 2021-03-16 23:35 PDT by Kimmo Kinnunen
Modified: 2021-08-31 01:11 PDT (History)
8 users (show)

See Also:

Patch (38.77 KB, patch)
2021-08-26 12:15 PDT, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff
Patch (33.95 KB, patch)
2021-08-26 12:24 PDT, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-03-16 23:35:08 PDT
webgl/1.0.4/conformance/glsl/misc/fragcolor-fragdata-invariant.html fails
Comment 1 Kimmo Kinnunen 2021-03-17 01:21:48 PDT

Declaring both gl_FragColor and gl_FragData invariant should succeed.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

test: Declaring both gl_FragColor and gl_FragData invariant should succeed.
default vertex shader
default vertex shader translated for driver
test fragment shader
FAIL [unexpected fragment shader compile status] (expected: true) Declaring both gl_FragColor and gl_FragData invariant should succeed.
test fragment shader info log
PASS successfullyParsed is true

Comment 2 Kimmo Kinnunen 2021-03-17 01:38:05 PDT
*** Bug 223334 has been marked as a duplicate of this bug. ***
Comment 3 Kimmo Kinnunen 2021-03-17 01:45:42 PDT
At least macOS 11.3, iMacPro1,1, Radeon Pro Vega 56
Comment 4 Radar WebKit Bug Importer 2021-03-23 23:36:29 PDT
Comment 5 Kimmo Kinnunen 2021-08-26 12:15:59 PDT
Created attachment 436543 [details]
Comment 6 Kimmo Kinnunen 2021-08-26 12:24:55 PDT
Created attachment 436546 [details]
Comment 7 EWS Watchlist 2021-08-26 12:26:14 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 8 Kenneth Russell 2021-08-26 22:37:28 PDT
Comment on attachment 436546 [details]

Great work Kimmo diagnosing and fixing this. It sounds like you've carefully analyzed what was going wrong here, so looks good to me. It would be good if Kyle could look at this too before landing.

(As an aside, I wish we'd finished the upstreaming process so that large changes like this didn't make WebKit's and ANGLE's code diverge further.)

Comment 9 Kimmo Kinnunen 2021-08-31 00:51:05 PDT
Discussing with Kyle, he thinks this is ok. To the best of my knowledge, all the expected conformance tests still pass.
Comment 10 EWS 2021-08-31 01:11:39 PDT
Committed r281794 (241131@main): <https://commits.webkit.org/241131@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436546 [details].