Bug 223317 – webgl/1.0.x/conformance/glsl/misc/fragcolor-fragdata-invariant.html fails

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Kimmo Kinnunen]

webgl/1.0.4/conformance/glsl/misc/fragcolor-fragdata-invariant.html fails

[Kimmo Kinnunen]

https://www.khronos.org/registry/webgl/sdk/tests/conformance/glsl/misc/fragcolor-fragdata-invariant.html?webglVersion=1&quiet=0&quick=1

Declaring both gl_FragColor and gl_FragData invariant should succeed.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".


test: Declaring both gl_FragColor and gl_FragData invariant should succeed.
default vertex shader
default vertex shader translated for driver
test fragment shader
FAIL [unexpected fragment shader compile status] (expected: true) Declaring both gl_FragColor and gl_FragData invariant should succeed.
test fragment shader info log
PASS successfullyParsed is true

TEST COMPLETE

[Kimmo Kinnunen]

*** Bug 223334 has been marked as a duplicate of this bug. ***

[Kimmo Kinnunen]

At least macOS 11.3, iMacPro1,1, Radeon Pro Vega 56

[Radar WebKit Bug Importer]

<rdar://problem/75772659>

[Kimmo Kinnunen]

Created attachment 436543 [details]
Patch

[Kimmo Kinnunen]

Created attachment 436546 [details]
Patch

[EWS Watchlist]

Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE

[Kenneth Russell]

Comment on attachment 436546 [details]
Patch

Great work Kimmo diagnosing and fixing this. It sounds like you've carefully analyzed what was going wrong here, so looks good to me. It would be good if Kyle could look at this too before landing.

(As an aside, I wish we'd finished the upstreaming process so that large changes like this didn't make WebKit's and ANGLE's code diverge further.)

r+

[Kimmo Kinnunen]

Discussing with Kyle, he thinks this is ok. To the best of my knowledge, all the expected conformance tests still pass.

[EWS]

Committed r281794 (241131@main): <https://commits.webkit.org/241131@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436546 [details].