Bug 223063 - Fix table-element-001.html
Summary: Fix table-element-001.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks: 47738
  Show dependency treegraph
 
Reported: 2021-03-11 01:41 PST by Rob Buis
Modified: 2021-03-15 23:56 PDT (History)
8 users (show)

See Also:


Attachments
Patch (4.54 KB, patch)
2021-03-11 01:44 PST, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (5.30 KB, patch)
2021-03-12 02:51 PST, Rob Buis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2021-03-11 01:41:43 PST
Fix table-element-001.html.
Comment 1 Rob Buis 2021-03-11 01:44:16 PST
Created attachment 422916 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-03-11 13:53:12 PST
Comment on attachment 422916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422916&action=review

> Source/WebCore/rendering/RenderBox.cpp:5101
> +    if (!style().hasAspectRatio() || isTablePart())

This would be cleaner if you had a function called ignoresAspectRatio() or something.
Comment 3 Rob Buis 2021-03-12 02:51:04 PST
Created attachment 423028 [details]
Patch
Comment 4 Rob Buis 2021-03-12 07:31:04 PST
Comment on attachment 422916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422916&action=review

>> Source/WebCore/rendering/RenderBox.cpp:5101
>> +    if (!style().hasAspectRatio() || isTablePart())
> 
> This would be cleaner if you had a function called ignoresAspectRatio() or something.

Sure, done.
Comment 5 EWS 2021-03-15 23:55:54 PDT
Committed r274467: <https://commits.webkit.org/r274467>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423028 [details].
Comment 6 Radar WebKit Bug Importer 2021-03-15 23:56:20 PDT
<rdar://problem/75465998>